Overview
Request 1143519 accepted
- Change YAML::XS::LibYAML to YAML::XS as this is the module to be used
The documented usage is `use YAML::XS 'Load'`.
I also searched the pcp code and that is what they are using: https://github.com/search?q=repo%3Aperformancecopilot%2Fpcp%20YAML%3A%3AXS&type=code
Using YAML::XS::LibYAML::Load() even coredumps here.
So I think it would be better to require the official module here.
It might also need an upstream fix. I'll try to make a PR to the git repo.
- Created by tinita
- In state accepted
- 4 package maintainers
Request History
tinita created request
- Change YAML::XS::LibYAML to YAML::XS as this is the module to be used
The documented usage is `use YAML::XS 'Load'`.
I also searched the pcp code and that is what they are using: https://github.com/search?q=repo%3Aperformancecopilot%2Fpcp%20YAML%3A%3AXS&type=code
Using YAML::XS::LibYAML::Load() even coredumps here.
So I think it would be better to require the official module here.
It might also need an upstream fix. I'll try to make a PR to the git repo.
mschreiner accepted request
Looks good, thank you!
I also created this upstream PR: https://github.com/performancecopilot/pcp/pull/1880
@dmdiss, @kwk, @mschreiner, @msmeissn: review reminder