Overview

Request 139712 superseded

- Create ntadmin group only if it doesn't yet exist.
- Update to 3.6.9.
+ When setting a non-default ACL, don't forget to apply masks to
SMB_ACL_USER and SMB_ACL_GROUP entries; (bso#9236).
+ Winbind can't fetch user or group info from AD via LDAP; (bso#9147).
+ Fix segfault in smbd if user specified ports out for range; (bso#9218).
- quota: Don't force the block size to 512; (bso#3272).
- Fix poll replacement to become a msleep replacement; (bso#8107).
- Fix wrong test == syntax in configure; (bso#8146).
- Fix --with(out)-sendfile-support option handling in autoconf; (bso#8344).
- Fix builtin forms order to match Windows again; (bso#8632).
- Fix RAW printing for normal users; (bso#8769).
- Initialise ticket to ensure we do not invalid memory; (bso#8788).
- Fix 'net rpc share allowedusers' to work with 2008r2; (bso#8966).
- Fix crash on null pam change pw response; (bso#9013).
- Connection to outbound trusted domain goes offline; (bso#9016).
- Increase debug level for info that the db is empty; (bso#9112).
- 'smbclient' can't connect to a Windows 7 server using NTLMv2; (bso#9117).
- Winbind can't fetch user or group info from AD via LDAP; (bso#9147).
- Open printers with the right access mask; (bso#9154).
- Fix makerpms.sh on RHEL; (bso#9165).
- Remove non-existent option '-Y' from winbindd manpage; (bso#9171).
- Add quota support for gfs2; (bso#9172).
- Make SMB2 compound request create/delete_on_close/close work as Windows;
(bso#9173).
- Empty SPNEGO packet can cause smbd to crash; (bso#9174).
- pam_winbind: Match more return codes when wbcGetPwnam has failed;
(bso#9177).
- Fix crash bug in idmap_hash; (bso#9188).
- SMB2 Create doesn't return correct MAX ACCESS access mask in blob;
(bso#9189).
- Fix service control for non-internal services; (bso#9192).
- Don't take 'state->te' as indication for "was_deferred"; (bso#9196).
- Parse of invalid SMB2 create blob can cause smbd crash; (bso#9209).
- Bad ASN.1 NegTokenInit packet can cause invalid free; (bso#9213).
- Fix segfault in smbd if user specified ports out for range; (bso#9218).
- Signing cannot be disabled for SMB2 by design, so fix the documentation
instead; (bso#9222).
- Fix NT_STATUS_IO_TIMEOUT during slow import of printers into registry;
(bso#9231).
- When setting a non-default ACL, don't forget to apply masks to SMB_ACL_USER
and SMB_ACL_GROUP entries; (bso#9236).
- lib-addns: ensure that allocated buffer are pre set to 0; (bso#9259).
- Make tdb robust against shrinking tdbs and improper CLEAR_IF_FIRST restart;
(bso#9268).
- Add support for reloading systemd services; (bso#9280).
- Warn via the smbd log if AppArmor and "wide links" are in use; (bnc#783719).

Loading...
Request History
Lars Müller's avatar

lmuelle created request

- Create ntadmin group only if it doesn't yet exist.
- Update to 3.6.9.
+ When setting a non-default ACL, don't forget to apply masks to
SMB_ACL_USER and SMB_ACL_GROUP entries; (bso#9236).
+ Winbind can't fetch user or group info from AD via LDAP; (bso#9147).
+ Fix segfault in smbd if user specified ports out for range; (bso#9218).
- quota: Don't force the block size to 512; (bso#3272).
- Fix poll replacement to become a msleep replacement; (bso#8107).
- Fix wrong test == syntax in configure; (bso#8146).
- Fix --with(out)-sendfile-support option handling in autoconf; (bso#8344).
- Fix builtin forms order to match Windows again; (bso#8632).
- Fix RAW printing for normal users; (bso#8769).
- Initialise ticket to ensure we do not invalid memory; (bso#8788).
- Fix 'net rpc share allowedusers' to work with 2008r2; (bso#8966).
- Fix crash on null pam change pw response; (bso#9013).
- Connection to outbound trusted domain goes offline; (bso#9016).
- Increase debug level for info that the db is empty; (bso#9112).
- 'smbclient' can't connect to a Windows 7 server using NTLMv2; (bso#9117).
- Winbind can't fetch user or group info from AD via LDAP; (bso#9147).
- Open printers with the right access mask; (bso#9154).
- Fix makerpms.sh on RHEL; (bso#9165).
- Remove non-existent option '-Y' from winbindd manpage; (bso#9171).
- Add quota support for gfs2; (bso#9172).
- Make SMB2 compound request create/delete_on_close/close work as Windows;
(bso#9173).
- Empty SPNEGO packet can cause smbd to crash; (bso#9174).
- pam_winbind: Match more return codes when wbcGetPwnam has failed;
(bso#9177).
- Fix crash bug in idmap_hash; (bso#9188).
- SMB2 Create doesn't return correct MAX ACCESS access mask in blob;
(bso#9189).
- Fix service control for non-internal services; (bso#9192).
- Don't take 'state->te' as indication for "was_deferred"; (bso#9196).
- Parse of invalid SMB2 create blob can cause smbd crash; (bso#9209).
- Bad ASN.1 NegTokenInit packet can cause invalid free; (bso#9213).
- Fix segfault in smbd if user specified ports out for range; (bso#9218).
- Signing cannot be disabled for SMB2 by design, so fix the documentation
instead; (bso#9222).
- Fix NT_STATUS_IO_TIMEOUT during slow import of printers into registry;
(bso#9231).
- When setting a non-default ACL, don't forget to apply masks to SMB_ACL_USER
and SMB_ACL_GROUP entries; (bso#9236).
- lib-addns: ensure that allocated buffer are pre set to 0; (bso#9259).
- Make tdb robust against shrinking tdbs and improper CLEAR_IF_FIRST restart;
(bso#9268).
- Add support for reloading systemd services; (bso#9280).
- Warn via the smbd log if AppArmor and "wide links" are in use; (bnc#783719).


Factory Auto's avatar

factory-auto declined request

Output of check script:
Source validator failed. Try "osc service localrun source_validator"
- package has baselibs.conf: (unchanged)
(E) Attention, samba-3.6.8.tar.bz2 is not mentioned in spec files as source or patch.
WARNING: macro used in version line
packager is responsible that the resulting string
is non-empty and contains no "-".
----------
%package -n libtalloc2
Version: %{libtalloc_ver}
%package -n libtalloc-devel
Version: %{libtalloc_ver}
%package -n libtdb1
Version: %{libtdb_ver}
%package -n libtdb-devel
Version: %{libtdb_ver}
%package -n libtevent0
Version: %{libtevent_ver}
%package -n libtevent-devel
Version: %{libtevent_ver}
%package -n libldb1
Version: %{libldb_ver}
%package -n libldb-devel
Version: %{libldb_ver}
----------
--------------------------------------------------------------
samba.spec has a %pre with groupadd and/or useradd
please check if this is ok:

-----------------master-table-entry:--------------------------
/work/cd/lib/misc/group:samba ntadmin:x:71:

-----------------specfile section:----------------------------
%pre
getent group ntadmin >/dev/null || groupadd -g 71 -o -r ntadmin || :

%preun
%pre client
# non SUSE + 11.3 an newer, update, no cifstab, but smbfstab
if [ ! 0%{?suse_version} -lt 1121 -a \
${1:-0} -gt 1 -a \
! -e /etc/samba/cifstab -a \
-f /etc/samba/smbfstab ]; then
cp -a /etc/samba/smbfstab /var/adm/backup/etc_samba_smbfstab-move
chkconfig -c smbfs && >/var/adm/backup/etc_samba_smbfs-enabled || :
fi

%preun client
%pre doc
# Remove all directories and files from usr/share/samba/swat/help expect welcome-*.html
if [ -d usr/share/samba/swat/help ]; then
find usr/share/samba/swat/help -mindepth 1 -maxdepth 1 -type d -print0 | \
xargs -0 rm -rf
for file in $( find usr/share/samba/swat/help -maxdepth 1 -type f); do
case "${file}" in
usr/share/samba/swat/help/welcome*.html) continue ;;
*) rm -f "${file}" ;;
esac
done
fi
%endif
%pre winbind
# we need this group for squid (ntlmauth)
# read access to /var/lib/samba/winbindd_privileged
%{_bindir}/getent group winbind >/dev/null || \
%{_sbindir}/groupadd -r winbind

%post winbind
%preun winbind
%{?stop_on_removal:%{stop_on_removal winbind}}

%postun winbind
--------------------------------------------------------------


Lars Müller's avatar

lmuelle superseded request

- Ensure adding the winbind group never can fail.
- Create ntadmin group only if it doesn't yet exist.
- Update to 3.6.9.
+ When setting a non-default ACL, don't forget to apply masks to
SMB_ACL_USER and SMB_ACL_GROUP entries; (bso#9236).
+ Winbind can't fetch user or group info from AD via LDAP; (bso#9147).
+ Fix segfault in smbd if user specified ports out for range; (bso#9218).
- quota: Don't force the block size to 512; (bso#3272).
- Fix poll replacement to become a msleep replacement; (bso#8107).
- Fix wrong test == syntax in configure; (bso#8146).
- Fix --with(out)-sendfile-support option handling in autoconf; (bso#8344).
- Fix builtin forms order to match Windows again; (bso#8632).
- Fix RAW printing for normal users; (bso#8769).
- Initialise ticket to ensure we do not invalid memory; (bso#8788).
- Fix 'net rpc share allowedusers' to work with 2008r2; (bso#8966).
- Fix crash on null pam change pw response; (bso#9013).
- Connection to outbound trusted domain goes offline; (bso#9016).
- Increase debug level for info that the db is empty; (bso#9112).
- 'smbclient' can't connect to a Windows 7 server using NTLMv2; (bso#9117).
- Winbind can't fetch user or group info from AD via LDAP; (bso#9147).
- Open printers with the right access mask; (bso#9154).
- Fix makerpms.sh on RHEL; (bso#9165).
- Remove non-existent option '-Y' from winbindd manpage; (bso#9171).
- Add quota support for gfs2; (bso#9172).
- Make SMB2 compound request create/delete_on_close/close work as Windows;
(bso#9173).
- Empty SPNEGO packet can cause smbd to crash; (bso#9174).
- pam_winbind: Match more return codes when wbcGetPwnam has failed;
(bso#9177).
- Fix crash bug in idmap_hash; (bso#9188).
- SMB2 Create doesn't return correct MAX ACCESS access mask in blob;
(bso#9189).
- Fix service control for non-internal services; (bso#9192).
- Don't take 'state->te' as indication for "was_deferred"; (bso#9196).
- Parse of invalid SMB2 create blob can cause smbd crash; (bso#9209).
- Bad ASN.1 NegTokenInit packet can cause invalid free; (bso#9213).
- Fix segfault in smbd if user specified ports out for range; (bso#9218).
- Signing cannot be disabled for SMB2 by design, so fix the documentation
instead; (bso#9222).
- Fix NT_STATUS_IO_TIMEOUT during slow import of printers into registry;
(bso#9231).
- When setting a non-default ACL, don't forget to apply masks to SMB_ACL_USER
and SMB_ACL_GROUP entries; (bso#9236).
- lib-addns: ensure that allocated buffer are pre set to 0; (bso#9259).
- Make tdb robust against shrinking tdbs and improper CLEAR_IF_FIRST restart;
(bso#9268).
- Add support for reloading systemd services; (bso#9280).
- Warn via the smbd log if AppArmor and "wide links" are in use; (bnc#783719).


Saul Goodman's avatar

licensedigger accepted review

{"approve": "version update 3.6.8 -> 3.6.9 covered by ldb"}


Factory Auto's avatar

factory-auto declined review

Output of check script:
Source validator failed. Try "osc service localrun source_validator"
- package has baselibs.conf: (unchanged)
(E) Attention, samba-3.6.8.tar.bz2 is not mentioned in spec files as source or patch.
WARNING: macro used in version line
packager is responsible that the resulting string
is non-empty and contains no "-".
----------
%package -n libtalloc2
Version: %{libtalloc_ver}
%package -n libtalloc-devel
Version: %{libtalloc_ver}
%package -n libtdb1
Version: %{libtdb_ver}
%package -n libtdb-devel
Version: %{libtdb_ver}
%package -n libtevent0
Version: %{libtevent_ver}
%package -n libtevent-devel
Version: %{libtevent_ver}
%package -n libldb1
Version: %{libldb_ver}
%package -n libldb-devel
Version: %{libldb_ver}
----------
--------------------------------------------------------------
samba.spec has a %pre with groupadd and/or useradd
please check if this is ok:

-----------------master-table-entry:--------------------------
/work/cd/lib/misc/group:samba ntadmin:x:71:

-----------------specfile section:----------------------------
%pre
getent group ntadmin >/dev/null || groupadd -g 71 -o -r ntadmin || :

%preun
%pre client
# non SUSE + 11.3 an newer, update, no cifstab, but smbfstab
if [ ! 0%{?suse_version} -lt 1121 -a \
${1:-0} -gt 1 -a \
! -e /etc/samba/cifstab -a \
-f /etc/samba/smbfstab ]; then
cp -a /etc/samba/smbfstab /var/adm/backup/etc_samba_smbfstab-move
chkconfig -c smbfs && >/var/adm/backup/etc_samba_smbfs-enabled || :
fi

%preun client
%pre doc
# Remove all directories and files from usr/share/samba/swat/help expect welcome-*.html
if [ -d usr/share/samba/swat/help ]; then
find usr/share/samba/swat/help -mindepth 1 -maxdepth 1 -type d -print0 | \
xargs -0 rm -rf
for file in $( find usr/share/samba/swat/help -maxdepth 1 -type f); do
case "${file}" in
usr/share/samba/swat/help/welcome*.html) continue ;;
*) rm -f "${file}" ;;
esac
done
fi
%endif
%pre winbind
# we need this group for squid (ntlmauth)
# read access to /var/lib/samba/winbindd_privileged
%{_bindir}/getent group winbind >/dev/null || \
%{_sbindir}/groupadd -r winbind

%post winbind
%preun winbind
%{?stop_on_removal:%{stop_on_removal winbind}}

%postun winbind
--------------------------------------------------------------

openSUSE Build Service is sponsored by