Request History
coolo created request
pleasing michal
factory-auto added a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
factory-auto added a reviewer
Please review build success
factory-auto added a reviewer
Check Staging Project
licensedigger added a reviewer
{"delegate": "new package r>3"}
licensedigger accepted review
{"delegate": "new package r>3"}
coolo accepted review
Not core enough for our staging
factory-repo-checker accepted review
Builds for repo openSUSE_Factory
factory-maintainer accepted review
ciaran reviewed the previous request
saschpe declined request
Since you have tk_version_supported, shouldn't the tk-devel (and hence freetype2-devel) be conditionalized as well? %preun seems to not cleanup rake / rdoc alternatices.
W: pem-certificate /usr/lib64/ruby/2.1.0/rubygems/ssl_certs
looks like security would want to see a patch to /etc/ssl/certs instead.
+# we know some tests will fail when they do not find a /usr/bin/ruby
Unimportant but maybe adjusting PATH would be enough?
Ruby20 has it too, but why devel-extra rather than extra-devel? Saves two rpmlint warnings and easier to search for.
Shouldn't we split out +%{_libdir}/libruby%{rb_binary_suffix}.so.2.1* into it's own shlib pkg for greater good?
+%{_libdir}/libruby%{rb_binary_suffix}-static.a
means the devel pkg should probably provide devel-static or just drop the file (shlib policy again).
saschpe declined review
Since you have tk_version_supported, shouldn't the tk-devel (and hence freetype2-devel) be conditionalized as well? %preun seems to not cleanup rake / rdoc alternatices.
W: pem-certificate /usr/lib64/ruby/2.1.0/rubygems/ssl_certs
looks like security would want to see a patch to /etc/ssl/certs instead.
+# we know some tests will fail when they do not find a /usr/bin/ruby
Unimportant but maybe adjusting PATH would be enough?
Ruby20 has it too, but why devel-extra rather than extra-devel? Saves two rpmlint warnings and easier to search for.
Shouldn't we split out +%{_libdir}/libruby%{rb_binary_suffix}.so.2.1* into it's own shlib pkg for greater good?
+%{_libdir}/libruby%{rb_binary_suffix}-static.a
means the devel pkg should probably provide devel-static or just drop the file (shlib policy again).
coolo revoked request
Klaus will fix it all
