Overview
Request 245740 revoked
- Created by michael-chang
- In state revoked
- Open review for openSUSE:Factory:Staging:B
Request History
michael-chang created request
licensedigger accepted review
{"approve": "license and version number unchanged: 2.02~beta2"}
factory-auto added a reviewer
Please review sources
factory-auto added a reviewer
Please review build success
factory-auto added a reviewer
Pick Staging Project
factory-auto accepted review
Check script succeeded
mlin7442 added a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:B"
mlin7442 accepted review
Picked openSUSE:Factory:Staging:B
factory-repo-checker accepted review
Builds for repo openSUSE:Factory:Staging:B/standard
dimstar declined review
Please see
http://en.opensuse.org/openSUSE:Packaging_Patches_guidelines#Patch_live_cycle
=> Added / removed patches need to be mentioned by name in .changes, in
order to get a full trail of life cycles.
Actually, the guideline already clearly states:
Patches need to be added to packages for various reasons and it is important that the life cycle of a patch is well-defined. This helps in preventing that patches get "lost" and nobody knows why and when it was removed. The life cycle is defined in these simple steps:
Patch added to the package
Patch is modified (functional/rebased)
Patch is disabled (but not deleted)
Patch removed from the package
The middle stages of the patch life cycle are optional and not every patch will live through them.
Any of those stages needs to be mentioned in the .changes file, including the file name of the patch. This is only for the benefit of human readers, so does not need to be in a strict machine-parseable format;
dimstar declined request
Please see
http://en.opensuse.org/openSUSE:Packaging_Patches_guidelines#Patch_live_cycle
=> Added / removed patches need to be mentioned by name in .changes, in
order to get a full trail of life cycles.
Actually, the guideline already clearly states:
Patches need to be added to packages for various reasons and it is important that the life cycle of a patch is well-defined. This helps in preventing that patches get "lost" and nobody knows why and when it was removed. The life cycle is defined in these simple steps:
Patch added to the package
Patch is modified (functional/rebased)
Patch is disabled (but not deleted)
Patch removed from the package
The middle stages of the patch life cycle are optional and not every patch will live through them.
Any of those stages needs to be mentioned in the .changes file, including the file name of the patch. This is only for the benefit of human readers, so does not need to be in a strict machine-parseable format;
michael-chang revoked request
ok