Overview
Request 247993 superseded
- readd isdv4-serial-inputattach and isdv4-serial-debugger
(bnc#895547)
- Created by eeich
- In state superseded
- Superseded by 396835
- Open review for factory-repo-checker
- Open review for openSUSE:Factory:Staging:B
Request History
eeich created request
- readd isdv4-serial-inputattach and isdv4-serial-debugger
(bnc#895547)
factory-auto added a reviewer
Please review sources
factory-auto added a reviewer
Please review build success
factory-auto added a reviewer
Pick Staging Project
factory-auto accepted review
Check script succeeded
licensedigger accepted review
{"approve": "license and version number unchanged: 0.24.0"}
coolo added a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:B"
coolo accepted review
Picked openSUSE:Factory:Staging:B
dimstar declined request
+%{!?install_serial:%exclude} %{_udevrulesdir}/65-wacom.rules
+%{!?install_serial:%exclude} %{_unitdir}/wacom-inputattach@.service
%exclude is actually not meant to 'skip' files alltogether - but have them skipped by globbing to get them in a different subpackage (simply try it on a binary file - and you will be surprised by the fun error message received)
Additionally, this will even break as you have higher in the .spec:
# if we don't package these remove them so no debuginfo files will be generated
%{!?install_serial: rm %{buildroot}%{_bindir}/isdv4-serial-inputattach %{buildroot}%{_bindir}/isdv4-serial-debugger
So in case the install_serial is not true, the files are being deleted and can no longer be excluded
dimstar declined review
+%{!?install_serial:%exclude} %{_udevrulesdir}/65-wacom.rules
+%{!?install_serial:%exclude} %{_unitdir}/wacom-inputattach@.service
%exclude is actually not meant to 'skip' files alltogether - but have them skipped by globbing to get them in a different subpackage (simply try it on a binary file - and you will be surprised by the fun error message received)
Additionally, this will even break as you have higher in the .spec:
# if we don't package these remove them so no debuginfo files will be generated
%{!?install_serial: rm %{buildroot}%{_bindir}/isdv4-serial-inputattach %{buildroot}%{_bindir}/isdv4-serial-debugger
So in case the install_serial is not true, the files are being deleted and can no longer be excluded
superseded by 396835