Overview
Request 459210 revoked
new package icinga2
- Created by ecsos
- In state revoked
- Open review for server:monitoring / icinga2
-
Open review for
factory-repo-checker
- Open review for openSUSE:Factory:Staging:adi:149
Request History
ecsos created request
new package icinga2
maxlin_factory added openSUSE:Factory:Staging:adi:9 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:9"
maxlin_factory accepted review
Picked openSUSE:Factory:Staging:adi:9
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added factory-repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
factory-repo-checker reopened review
can't install icingaweb2-module-director-1.3.0-3.1.noarch:
package icingaweb2-module-director-1.3.0-3.1.noarch requires icingaweb2 >= 2.2.0, but none of the providers can be installed
package icingaweb2-2.4.1-12.1.noarch requires php-Icinga = 2.4.1, but none of the providers can be installed
nothing provides php5-ZendFramework >= 1.12.18 needed by php-Icinga-2.4.1-12.1.noarch
(we have php5-ZendFramework-1.12.17-1.2.noarch)
found conflict of icinga-1.14.0-1.1.x86_64 with icinga2-classicui-config-2.6.2-2.1.x86_64:
- /etc/icinga [mode mismatch: d775 root:root, d751 icinga:icinga]
jengelh declined review
* Drop %clean
* Drop conditionals %if 0%{?suse_version} >= 1310 ... it's long EOL and just baggage.
* nano-icinga2 could gain a "Supplements: packageand(nano:icinga2)"
* vim-icinga2 could gain a "Supplements: packageand(vim:icinga2)"
* It should have all Group: lines should be System/Monitoring
* icinga2-doc should have Group: Documentation/Other
* icinga2-selinux should have Group: System/Base
* icinga2 does not need a Requires: icinga2-libs = %{version}, because the libs are already properly versioned in their own right.
* ido-pgsql and ido-mysql don't need Requires: %{name} = %{version} because they already have a fully-versioned dependency on the libs.
* icinga2-bin is unnecessary and can just be moved into icinga2
* icinga2-libs is unnecessary too and can just be moved into icinga2 - in particular since it is version-dependent on its libs.
jengelh declined request
* Drop %clean
* Drop conditionals %if 0%{?suse_version} >= 1310 ... it's long EOL and just baggage.
* nano-icinga2 could gain a "Supplements: packageand(nano:icinga2)"
* vim-icinga2 could gain a "Supplements: packageand(vim:icinga2)"
* It should have all Group: lines should be System/Monitoring
* icinga2-doc should have Group: Documentation/Other
* icinga2-selinux should have Group: System/Base
* icinga2 does not need a Requires: icinga2-libs = %{version}, because the libs are already properly versioned in their own right.
* ido-pgsql and ido-mysql don't need Requires: %{name} = %{version} because they already have a fully-versioned dependency on the libs.
* icinga2-bin is unnecessary and can just be moved into icinga2
* icinga2-libs is unnecessary too and can just be moved into icinga2 - in particular since it is version-dependent on its libs.
ecsos reopened request
Please accept it because the spec is from upstream.
When we would use our own spec we must maintain it.
So, when you accept, upstream does this for us and we have much less work.
You can also contact the maintainer in server:monitoring:icinga2.
I have communicated with him.
factory-repo-checker reopened review
Execution plan: server:monitoring/openSUSE_Factory
found conflict of icinga-1.14.0-2.1.x86_64 with icinga2-classicui-config-2.6.2-1.1.x86_64:
- /etc/icinga [mode mismatch: d775 root:root, d751 icinga:icinga]
Execution plan: server:monitoring/openSUSE_Tumbleweed
found conflict of icinga-1.14.0-2.1.x86_64 with icinga2-classicui-config-2.6.2-1.1.x86_64:
- /etc/icinga [mode mismatch: d775 root:root, d751 icinga:icinga]
maxlin_factory accepted review
Re-evaluation needed
maxlin_factory added factory-staging as a reviewer
Requesting new staging review
maxlin_factory added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:149"
maxlin_factory accepted review
Picked openSUSE:Factory:Staging:adi:149
licensedigger accepted review
ok
dimstar declined review
declining - please sort out the file conflict, either by not having the conflict in first place or explicitly declaring icinga2 conflicting icinga (e.g. Conflicts: icinga)
dimstar declined request
declining - please sort out the file conflict, either by not having the conflict in first place or explicitly declaring icinga2 conflicting icinga (e.g. Conflicts: icinga)
ecsos revoked request
okay. I the rights in icinga2 are more restrictive thant in icinga v1. So, the problem is in icinga v1, i think? And icinga v1 and icinga2 should not install combined. So, what can we do?
if icinga 2 is replacing icinga 2 (why use a 2nd name then?( one could use Obsoletes
if the two are simply known to conflict, the Conflicts: icinga in icinga2.spec is also going to work
so, what approach to resolve the conflict is being taken? As long as this is not addressed, this request can't proceed
I don't know what to do. I have test installations in different ways. And all was right. No problem by install. When i understand it right, so icinga2-classicui-config use the old gui with the new icinga2 and it need for that the old icinga-www but not old icinga itself. So why come this error in factory build but not in server:monitoring build? I don't understand this.
There is no build issue - there is the issue that both icinga versions install the same directory with different permissions - ultimately leading to 'random' permission set on the disk.
Either align the permissions between the two packages or, if icinga and icinga2 cannot be parallel installed, add conflicts: icinga to icinga2.spec
From icinga you can download icinga and icinga2. So it exists two versions. And the spec from icinga2 is from upstream.