This request is superseded by
request 483902
(Show diff)
Overview
Request 479398 superseded
No description set
- Created by totol
- In state superseded
-
Package maintainers:
gregfreemyer and
totol
- Supersedes 460784
- Superseded by 483902
-
Open review for
Loading...
Request History
totol created request
lrupp declined review
As discussed already in the comments, please bring the %defattr macro back into the %files sections. This is not automated and might become a security risk if not present.
lrupp declined request
As discussed already in the comments, please bring the %defattr macro back into the %files sections. This is not automated and might become a security risk if not present.
Why remove %defattr(-,root,root,-) from every %files section?
because the is the default case and it should work without it
I'm pretty sure the opensuse guidelines call to leave that explicitly in the %files section, but I don't know the reasoning.
At least for openSUSE 13.2 it was.
W: files-attr-not-set A file or a directory entry in a %files section does not have attributes set which may result in unexpected file permissions and thus security issues in the resulting binary package depending on the build environment and rpmbuild version (typically < 4.4). Add default attributes using %defattr before it in the %files section, or use per entry %attr's.