Overview

Request 483902 accepted

No description set

Aeneas Jaißle's avatar

Why remove %defattr(-,root,root,-) from every %files section?


Thomas ANDREJAK's avatar
author target maintainer

because the is the default case and it should work without it


Greg Freemyer's avatar

I'm pretty sure the opensuse guidelines call to leave that explicitly in the %files section, but I don't know the reasoning.


Aeneas Jaißle's avatar

At least for openSUSE 13.2 it was.

W: files-attr-not-set A file or a directory entry in a %files section does not have attributes set which may result in unexpected file permissions and thus security issues in the resulting binary package depending on the build environment and rpmbuild version (typically < 4.4). Add default attributes using %defattr before it in the %files section, or use per entry %attr's.

Request History
Thomas ANDREJAK's avatar

totol created request


Greg Freemyer's avatar

gregfreemyer accepted review

Looks good to me


Greg Freemyer's avatar

gregfreemyer accepted request

ok

openSUSE Build Service is sponsored by