Overview
Request 495490 superseded
Required for postgresql96 as noted in opensuse-factory list:
https://lists.opensuse.org/opensuse-factory/2017-05/msg00205.html
This will deviate from SLE, but it would seem either postgres96 should
be dropped since it is uninstalledable or this should be accepted.
One can see the missing requirements easily:
https://build.opensuse.org/package/binary/openSUSE:Leap:42.3/postgresql96?arch=x86_64&filename=postgresql96-server-9.6.2-1.10.x86_64.rpm&repository=standard
- Created by jberry
- In state superseded
- Superseded by 495569
-
Open review for
factory-staging
-
Open review for
leap-reviewers
Request History
jberry created request
Required for postgresql96 as noted in opensuse-factory list:
https://lists.opensuse.org/opensuse-factory/2017-05/msg00205.html
This will deviate from SLE, but it would seem either postgres96 should
be dropped since it is uninstalledable or this should be accepted.
One can see the missing requirements easily:
https://build.opensuse.org/package/binary/openSUSE:Leap:42.3/postgresql96?arch=x86_64&filename=postgresql96-server-9.6.2-1.10.x86_64.rpm&repository=standard
leaper added server:database:postgresql as a reviewer
Submission for None by someone who is not maintainer in the devel project (server:database:postgresql). Please review
leaper added leap-reviewers as a reviewer
leaper accepted review
ok
pluskalm accepted review
Looks reasonable
lnussel_factory superseded request
supersede
openSUSE:Factory/postgresql-init@14 -> openSUSE:Leap:42.3/postgresql-init
expected origin is 'SUSE:SLE-12:Update' (changed)
the submitted sources are in or accepted for Factory
cc @lnussel
Please reject. We are about to release PostgreSQL 9.6 for SLE12 and with that we'll also get a matching postgresql-init.
Assuming that update just uses the Factory package too we'd be fine.
The update uses the SLE12 package, which is ahead of Factory at this point regarding systemd migration. So Factory needs syncing with SLE12 not the other way around.
well, if that is the case could you do that please?
Hmm - on SLE12 we dropped support for init in favour of systemd, but for the devel project we still need SysV, because the project still builds against SLE11. This clutters the spec file with lots of %{with systemd} conditionals as we are building two almost distinct packages for SLE11 and SLE12.
This makes me wonder whether we should rather have two separate packages: postgresql-init for SLE11 and postgresql-systemd for SLE12.
From Factory PoV the devel project does not need to build for SLE11. If you need to keep a SLE11 compatible package for some reason feel free to fork the package and use a copy for SLE11. you can build disable the fork for Factory/SLE12 and in turn build disable the Factory package for sle11 then.
Anyway, for the time being it should be good enough to accept sr#495569 for SLE12 (and inherit to 42.3). I am well aware that the devel project needs resync and there is already a FATE about completing the migration of PostgreSQL to systemd, so it won't get forgotten for SLE13 even if we let Factory differ for now.
And Martin, would you please leave such reviews up to the respective bugowner (which would have been me in this case). "Looks reasonable" is OK as a comment, but the bugowner should have the last word on the actual Review. Thanks!
Note that is no such policy in general. How you deal with packages in your devel project needs to be agreed upon within your project. From tools perspective postgresql-init has no specific mainainer.