Overview
Request 498015 superseded
I'm pretty positive that just removing this build build flags works in
itself. The other change was redundant AFAICS.
- remove -fno-inline-small-functions which breaks with gcc7
(boo#1040105)
- Created by wrosenauer
- In state superseded
- Supersedes 497321
- Superseded by 498129
-
Open review for
opensuse-review-team
-
Open review for
factory-repo-checker
- Open review for openSUSE:Factory:Staging:C
Based on the comments in boo#1040105 - will r590 be submitted too or is there more work needed? (currently we have r589 in Staging:C, which fails for UI errors)
r590 could be submitted but I would rather try to remove the first workaround and see what happens.
Because currently I think we just have doubled the thing:
export CFLAGS="%{optflags} -fno-strict-aliasing" . . .
gcc7 (boo#1040105)
%if 0%{?suse_version} > 1320 ac_add_options --enable-optimize="-g -O2" %endif
Is it ok to do one more trial w/o the latter if it works?
yes, sure - in the end I would not want a submission which you as maintainer cannot support in good faith
Request History
wrosenauer created request
I'm pretty positive that just removing this build build flags works in
itself. The other change was redundant AFAICS.
- remove -fno-inline-small-functions which breaks with gcc7
(boo#1040105)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added factory-repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
dimstar_suse set openSUSE:Factory:Staging:C as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:C"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:C
licensedigger accepted review
ok
factory-repo-checker reopened review
superseded by 498129
Firefox on KDE testrun: https://openqa.opensuse.org/tests/408504 - no joy