Request 500404 (accepted)

This request supersedes: request 499436 (Show diff)

Overview

Request 500404 accepted

No description set

Created by NMoreyChaisemartin almost 7 years ago
In state accepted
Supersedes 499436

Submit rdma-core

Comments for request 500404 4

Dominique Leuenberger (dimstar) - almost 7 years ago

reviewer

+sed 's%/usr/libexec%/usr/lib%'

Does not fail - but generally seen, I'd avoid using '%' in a spec file as it is the macro identifier for RPM; you can run into quite fun issues.

Jan Engelhardt (jengelh) - almost 7 years ago

reviewer

Can't go wrong with perl -e 's{/usr/libexec}{/usr/lib}'. Choosing a "symmetric" pair like { } means one can use the delimiter itself within without escape (s{{foo}}{bar}). It's clearly a win-win to use PCRE here..

Nicolas Morey-Chaisemartin (NMoreyChaisemartin) - almost 7 years ago

author

I copy/pasted what Philipp did :) This is what went into SP3 so I'd rather keep it this way for the moment if that's OK

Dominique Leuenberger (dimstar) - almost 7 years ago

reviewer

sure - it is no violation of any policy; I just thought I would raise it as depending on what you will want to do, it might or might not work as expected