Overview

Request 501559 superseded

No description set
Loading...
Request History
Bin Liu's avatar

BinLiu created request


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto added factory-repo-checker as a reviewer

Please review build success


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Staging Bot's avatar

staging-bot added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:171"


Staging Bot's avatar

staging-bot accepted review

Picked openSUSE:Factory:Staging:adi:171


Factory Repo Checker's avatar

factory-repo-checker accepted review

Builds for repo network:ha-clustering:Factory/openSUSE_Tumbleweed


Jan Engelhardt's avatar

jengelh declined review

%clean is redundant and should be removed.
rm -rf %buildroot in %install should be removed too. We do not need it in OBS.

I'll suggest Group: Productivity/Networking/Diagnostic

(You should probably run format_spec_file just like it is mentioned in the 5-line comment block you added at the top. But that's up to you.)


Jan Engelhardt's avatar

jengelh declined request

%clean is redundant and should be removed.
rm -rf %buildroot in %install should be removed too. We do not need it in OBS.

I'll suggest Group: Productivity/Networking/Diagnostic

(You should probably run format_spec_file just like it is mentioned in the 5-line comment block you added at the top. But that's up to you.)


Bin Liu's avatar

BinLiu superseded request

superseded by 505150

openSUSE Build Service is sponsored by