Overview
Request 561768 superseded
- Make sure to build just with python3
- Remove needles buildroot variable and default defattrs
- Use autopatch to apply patches (forwarded request 561689 from scarabeus_iv)
- Created by jengelh
- In state superseded
- Superseded by 573919
-
Open review for
legal-auto
-
Open review for
opensuse-review-team
-
Open review for
repo-checker
Request History
jengelh created request
- Make sure to build just with python3
- Remove needles buildroot variable and default defattrs
- Use autopatch to apply patches (forwarded request 561689 from scarabeus_iv)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
staging-bot set openSUSE:Factory:Staging:G as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:G"
staging-bot accepted review
Picked openSUSE:Factory:Staging:G
dimstar declined review
A minimal amount of testing in the devel is appreciated... like: does it build with python3, when python2 is not present - when the build requires are already explicitly changed.
Answer: no, since it uses python2 in the build root (python-base is still there, and apparently preferred; the fact this this built in Staging:O is only because there is no python2 available at all there)
[ 25s] cd /home/abuild/rpmbuild/BUILD/spirv-tools-2017.0.g103/build/source && /usr/bin/python /home/abuild/rpmbuild/BUILD/spirv-tools-2017.0.g103/utils/generate_registry_tables.py --xml=/usr/include/spirv/spir-v.xml --generator-output=/home/abuild/rpmbuild/BUILD/spirv-tools-2017.0.g103/build/generators.inc
[ 25s] Traceback (most recent call last):
[ 25s] File "/home/abuild/rpmbuild/BUILD/spirv-tools-2017.0.g103/utils/generate_registry_tables.py", line 21, in
[ 25s] import xml.etree.ElementTree
[ 25s] ImportError: No module named xml.etree.ElementTree
dimstar declined request
A minimal amount of testing in the devel is appreciated... like: does it build with python3, when python2 is not present - when the build requires are already explicitly changed.
Answer: no, since it uses python2 in the build root (python-base is still there, and apparently preferred; the fact this this built in Staging:O is only because there is no python2 available at all there)
[ 25s] cd /home/abuild/rpmbuild/BUILD/spirv-tools-2017.0.g103/build/source && /usr/bin/python /home/abuild/rpmbuild/BUILD/spirv-tools-2017.0.g103/utils/generate_registry_tables.py --xml=/usr/include/spirv/spir-v.xml --generator-output=/home/abuild/rpmbuild/BUILD/spirv-tools-2017.0.g103/build/generators.inc
[ 25s] Traceback (most recent call last):
[ 25s] File "/home/abuild/rpmbuild/BUILD/spirv-tools-2017.0.g103/utils/generate_registry_tables.py", line 21, in
[ 25s] import xml.etree.ElementTree
[ 25s] ImportError: No module named xml.etree.ElementTree
superseded by 573919
