Overview
Request 571906 superseded
- remove NameVirtualHost from documentation [bsc#1078557]
- for older distros, still use SuSEFirewall2 [bsc#1071548c#7]
- Replace SuSEFirewall2 by firewalld (fate#323460)
- Created by pgajdos
- In state superseded
- Supersedes 570890
- Superseded by 572001
-
Open review for
repo-checker
- Open review for openSUSE:Factory:Staging:B
Request History
pgajdos created request
- remove NameVirtualHost from documentation [bsc#1078557]
- for older distros, still use SuSEFirewall2 [bsc#1071548c#7]
- Replace SuSEFirewall2 by firewalld (fate#323460)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse set openSUSE:Factory:Staging:B as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:B"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:B
dimstar declined review
+%if %{use_firewalld}
+Source49: apache2.firewalld
+Source50: apache2.ssl.firewalld
+%else
+Source51: apache2.susefirewall
+Source52: apache2.ssl.susefirewall
+%endif
Please no conditionalizing of sources, as this break re-usability of src.rpms (the src.rpm of Leap 15.0 for example could not be used to rebuild by a user on Leap 42.x, as it would be missing files)
dimstar declined request
+%if %{use_firewalld}
+Source49: apache2.firewalld
+Source50: apache2.ssl.firewalld
+%else
+Source51: apache2.susefirewall
+Source52: apache2.ssl.susefirewall
+%endif
Please no conditionalizing of sources, as this break re-usability of src.rpms (the src.rpm of Leap 15.0 for example could not be used to rebuild by a user on Leap 42.x, as it would be missing files)
superseded by 572001
Very nice...
+%if %{use_firewalld} +Source49: apache2.firewalld +Source50: apache2.ssl.firewalld +%else +Source51: apache2.susefirewall +Source52: apache2.ssl.susefirewall +%endifnot that nice..
Conditionalize sources means non-reusable source rpms and is generally seen a really bad idea