Overview
Request 585034 superseded
Initial Factory submission. https://lists.opensuse.org/opensuse-factory/2018-03/msg00084.html
- Created by jfajerski
- In state superseded
- Supersedes 583785 583875
- Superseded by 707082
-
Open review for
repo-checker
Eh it's not such a good idea to copy-paste the git log... not in that length.
Maybe rather a link to the upstream change log? https://github.com/grafana/grafana/blob/v5.0.0/CHANGELOG.md
Along with packaging changes.
https://en.opensuse.org/openSUSE:Creating_a_changes_file_%28RPM%29#What_goes_into_the_changelog for more details about a good changelog entry.
Request History
jfajerski created request
Initial Factory submission. https://lists.opensuse.org/opensuse-factory/2018-03/msg00084.html
licensedigger accepted review
ok
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
staging-bot added openSUSE:Factory:Staging:adi:53 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:53"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:53
dimstar accepted review
dimstar_suse added openSUSE:Factory:Staging:adi:23 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:23"
dimstar_suse accepted review
Moved to openSUSE:Factory:Staging:adi:23
dimstar_suse accepted review
Reviewed by staging project "openSUSE:Factory:Staging:adi:23" with result: "accepted"
dimstar_suse added factory-staging as a reviewer
Please recheck
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:70"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:adi:70
dimstar declined review
nothing provides phantomjs
dimstar declined request
nothing provides phantomjs
@jfajerski see staging project comments by myself and repo-checker.
nothing provides phantomjs
This was noted before. From my understanding phantomjs is an optional dependency used to generate pngs of the graphs on demand. If you do not need pngs you do not need phantomjs.
Since upstream will have to deal with this anyway, how about we change to recommends for now.
Afaiu the grafana build process does not allow for phantomjs to be optional. Rather the grafana sources come with a pre-build binary (which we don't use, hence the dependency). I have not tested grafana without phantomjs.
So what's the conclusion? I see three choices:
@dimstart fwiw I'm tracking Grafana, the phantomjs dependency will be dropped before long.