Overview
Request 592117 accepted
- Enhance IO scheduler tweaking rules to support blk-mq as well
* Set optimal blk-mq schedulers (bfq and mq-deadline for HDD and
SSD respectively)
* Explicitly set CFQ for rotational disks when no `elevator`
is specified
* Verbose comments explaining what is going on
* Rename the rules file since it is not ssd-only anymore
Request History
develop7 created request
- Enhance IO scheduler tweaking rules to support blk-mq as well
* Set optimal blk-mq schedulers (bfq and mq-deadline for HDD and
SSD respectively)
* Explicitly set CFQ for rotational disks when no `elevator`
is specified
* Verbose comments explaining what is going on
* Rename the rules file since it is not ssd-only anymore
develop7 added mwilck as a reviewer
Hi Martin, I've followed your suggestions, please check it out
fbui added mwilck as a reviewer
Martin, could you ack this ? thanks.
mwilck accepted review
The syntax 'ENV{elevator}=="*?"' is a bit unusual ("?*" is typically used) but that's just a nitpick. Ack.
mwilck accepted review
The syntax 'ENV{elevator}=="*?"' is a bit unusual ("?*" is typically used) but that's just a nitpick. Ack.
mwilck approved review
The syntax 'ENV{elevator}=="*?"' is a bit unusual ("?*" is typically used) but that's just a nitpick. Ack.
fbui accepted request
@develop7: thanks !
@fbui the request has been acked by @mwilck, but it's still in new state. Is it stuck?
um. @systemd-maintainers anyone?
It's just that I haven't received any notification about your new submission, sorry for the delay.
I meant that I didn't see that Martin acked your changes.
Looks like the review flow has been stuck somehow.
Thanks!
Shouldn't it be picked for some staging project BTW?
@WernerFink, @elvigia, @fbui, @systemd-maintainers, @tsaupe: review reminder