Overview
Request 682766 superseded
- Add systemd logo icons
- Add LibreOffice branding
- optipng everything
- Base installer off of SVG
- Created by hellcp
- In state superseded
- Supersedes 682385
- Superseded by 682813
- Open review for factory-staging
- Open review for repo-checker
- Open review for opensuse-review-team
- Open review for leap-reviewers
Is there a reason why we add back libreoffice branding? After all openSUSE does not really maintain libreoffice so I'd actually favor keeping the upstream branding.
It was requested by LO community :D
because it's so great they want all the fame on openSUSE rather themselves?
wtf. can we help upstream to have a decent branding then? :)
is there a bug reference or something btw?
(I think splash screens and wallpapers of desktop environments are fine to brand as they are perceived as part of the OS. Applications are just that, applications.)
This breaks installation-images
[ 826s] running "/check_fonts usr/share/YaST2/theme" [ 827s] Error: font "Open Sans Condensed" not found; closest match(es): "Roboto" [ 827s] mk_image: execution of "/check_fonts usr/share/YaST2/theme" failed at lib/AddFiles.pm line 779 in data/root/root.file_list line 752. [ 827s] make: *** [Makefile:164: root] Error 1
i-i was checking all fonts be introduced by installation.qss has been included https://github.com/openSUSE/installation-images/blob/master/data/base/check_fonts#L23 , however the font change in installation.qss here doesn't.
I think the differ is that, yast2-qt-branding does not requires google-opensans-fonts?
Request History
hellcp created request
- Add systemd logo icons
- Add LibreOffice branding
- optipng everything
- Base installer off of SVG
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
origin-manager added opensuse-review-team as a reviewer
Additional review required based on origin.
origin-manager added leap-reviewers as a reviewer
unkown direction.
origin-manager added legal-auto as a reviewer
Additional review required based on origin.
origin-manager accepted review
origin: openSUSE:Leap:15.0:Update~
licensedigger accepted review
ok
seems you've fixed fonts requirement in your branch but not on this request?
Welp, didn't refresh the page after making a change :/