Overview

Request 692129 superseded

Ok let's keep the patch for now.

- Spec File cleanup:
- Switched to %autosetup %make_build to ease spec file maintanance
- Dropped obsolete macros
- Moved COPYING to %license

Loading...

Stefan Seyfried's avatar

This removes Patch1, is this intended? It was applied before...


Maurizio Galli's avatar
author source maintainer target maintainer

Actually I wanted to ask. there should have been a question in the comment... the patch added some support for a few MIME uri that don’t seem to be included upstream. Is it trivial to have such patch? There is no reference of bug report


Maurizio Galli's avatar
author source maintainer target maintainer

See this for rerference: https://wiki.debian.org/DebianMultimedia/PlayerSupport


Stefan Seyfried's avatar

Well, it seems that guido has thought about that and added it, maybe because it actually works. OTOH I have no idea what these scheme-handlers are good for :-)

I just wanted to point out that you remove the application of the patch without mentioning it in the changelog (might be a problem on forwarding to factory) and without removing the actual patch, which hinted me at an accidental change :-)


Maurizio Galli's avatar
author source maintainer target maintainer

OTOH I have no idea what these scheme-handlers are good for :-)

I raised it exactly because I don't know how to get those to work or whether Parole ACTUALLY works with them. I mean we could assume that the person who put them there had a good reason to, thus could just leave the patch for now and even better try to push it upstream?

I just wanted to point out that you remove the application of the patch without mentioning it in the changelog

Yes it would be a problem and that was me forgetting to mention it :-).

Request History
Maurizio Galli's avatar

mauriziogalli created request

Ok let's keep the patch for now.

- Spec File cleanup:
- Switched to %autosetup %make_build to ease spec file maintanance
- Dropped obsolete macros
- Moved COPYING to %license


openSUSE Build Service is sponsored by