This request is superseded by
request 708250
(Show diff)
You're not reviewing the full diff of
request 707012
, but the diff to the superseded
request 704036
(Show full diff)
Overview
Request 707012 superseded
No description set
- Created by hillwood
- In state superseded
- Supersedes 704036
- Superseded by 708250
-
Open review for
legal-auto
- Open review for openSUSE:Factory:Staging:adi:151
Loading...
Request History
hillwood created request
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:151"
dimstar_suse accepted review
Picked openSUSE:Factory:Staging:adi:151
dimstar accepted review
superseded by 708250
lib/animation.vala is GPL-3.0-only, the license shall be changed to "GPL-3.0-or-later AND GPL-3.0-only".
The parameters used on the %cmake line are also not useful. The %cmake macro already defines the compiler flags and CMAKE_INSTALL_DIR is not needed by deepin-terminal.
You can also change 'make %{?_smp_mflags}' → '%cmake_build'