Overview
Request 728996 accepted
- Update to 1.5.5:
* Development version using Qt5.
* Large code refactoring
* Many bugs fixed
- Check https://wiki.scribus.net/canvas/1.5.5_Release for more information
- Drop hunspell.patch
- Add 0001-Make-sure-information-displayed-on-the-about-window-.patch
- Created by cgiboudeaux
- In state accepted
- Supersedes 728484
Untested, something is broken on my system and I don't know what yet.
I probably just would have patched CMakeLists_Directories.cmake to set DOCDIR to something else (e.g. /usr/share/scribus/doc/), but ok that works as well... ;--)
that would also have installed the documentation in that folder.
Yes, but I don't see that as a problem.
Anyway, I'm fine with this solution as well.
We should probably check whether some of these removed Requires/Suggests would still make sense:
-Requires: ghostscript-library
-Requires: python-imaging
-Requires: tk
-Suggests: AdobeICCProfiles
-Suggests: Uniconvertor
Some of the shipped example scripts do require python-tk (tk alone is not enough), so maybe that should be Recommended.
python-imaging is needed by the "Direct image import" script, but a Recommends is probably enough here too.
python-imaging doesn't exist anymore though, the package providing it is python2-Pillow, and the script still complains "Unable to import the Python Imaging Library module" if I install that...
I assume it does
from PIL import Image
somewhere in the script. In Pillow this syntax is different. Probably worth a report upstream?
It does, but that's ok and works fine with Pillow ("import Image" alone wouldn't work).
I just didn't have it installed even though I thought I installed it.
Oops, it does work if I really install python2-Pillow... ;-) (I accidentally aborted the installation previously it seems)
So maybe that should still be Recommended.
ghostscript would be needed for opening PS files, but I suppose we shouldn't even Recommend it despite of that...
Uniconvertor is not in the distribution, only in the "graphics" repo (named "uniconvertor" with lower-case u):
https://build.opensuse.org/package/show/graphics/uniconvertor
No idea if that can be used by scribus in any way.
I'd probably leave the "Suggests: AdobeICCProfiles", but then it doesn't really matter much either...
There is a setting for the "UniConvertor" executable in scribus (in "External Tools"), but that's set to 'uniconv' by default which is part of yudit ("yudit is a unicode package to edit and convert text of different languages."), so seems to be something different anyway ("UniConvertor is a multiplatform universal vector graphics translator").
It seems that uniconvertor would be used to allow importing additional vector graphics formats:
https://wiki.scribus.net/canvas/GSoC_2008_UniConvertor_and_GraphicsMagick_integration
Indeed. From the 1.5.0 release notes:
Scribus will detect an installed version of UniConvertor and use it to import some of the vector formats supported by this program into Scribus.
https://wiki.scribus.net/canvas/1.5.0_Release
Thanks, I'm not really happy with new python2 dependencies if it's EOL in a few months. but I added recommends for python2-Pillow, python-tk and uniconvertor. I'll see if it needs an update then submit it to factory
Well, "new python2 dependencies" is relative as they were Requires until now... ;-)
Anyway, there is work going on to port it to python3:
https://bugs.scribus.net/view.php?id=15030
Apparently the patch there more or less works, though there still seem to be problems.
I also saw a uniconv 2.0 rc release but it looks like it's one one these projects that takes years to release anything.
I didn't see any shebang in the code, no idea if it still uses python2 :)
So, a local build doesn't crash (I use clang locally). Only noticeable thing is the difference in ldd's output. the obs build only lists libjpeg.so.8 while my local build also lists libjpeg.so.62.
I'm checking the build flags
Request History
cgiboudeaux created request
- Update to 1.5.5:
* Development version using Qt5.
* Large code refactoring
* Many bugs fixed
- Check https://wiki.scribus.net/canvas/1.5.5_Release for more information
- Drop hunspell.patch
- Add 0001-Make-sure-information-displayed-on-the-about-window-.patch
cgiboudeaux accepted request
No comment left, let's move on
FTR, the crash I had happens if scribus is built using -DCMAKE_BUILD_TYPE=RelWithDebInfo (what the %cmake macro does).
Which is interesting, because scribus overwrites that: https://github.com/scribusproject/scribus/blob/02e3f79825a619203a86aa1646adc0430d62cf0d/CMakeLists.txt#L296
the %cmake macro replaces lines containing CMAKE_BUILD_TYPE
When I removed the %cmake call, I tried using -DWANT_RELEASEWITHDEBUG, it also crashed. Without that enabled, it indeed builds with CMAKE_BUILD_TYPE=RELEASE. My conclusion is that
set(CMAKE_CXX_FLAGS_RELEASE "-O2 -Wall -fPIC")is the key. I guess it would crash without -fPIC enabled globally.This produces a rpmlint warning (scribus.x86_64: W: position-independent-executable-suggested /usr/bin/scribus) but it doesn't crash
Are there other comments?