Overview
Request 744318 accepted
- Fix mangling of shebangs, do not replace shell invocations with
ruby, correcly replace "/usr/bin/env ruby".
- Cleanup spec file:
* Drop support for obsolete distro versions
* use license macro, remove defattr
- Use valgrind-client-headers instead of full valgrind-devel package
where available, reducing build package footprint.
- Remove unused libX11-devel BuildRequires.
- Created by StefanBruens
- In state accepted
- Supersedes 743866
Request History
StefanBruens created request
- Fix mangling of shebangs, do not replace shell invocations with
ruby, correcly replace "/usr/bin/env ruby".
- Cleanup spec file:
* Drop support for obsolete distro versions
* use license macro, remove defattr
- Use valgrind-client-headers instead of full valgrind-devel package
where available, reducing build package footprint.
- Remove unused libX11-devel BuildRequires.
coolo accepted request
can you explain what was broken with the shebang code?
https://bugzilla.suse.com/show_bug.cgi?id=1156797
It replaces all shebangs with ruby (even bash)
Hello? Anyone at home?
This comment has been deleted
Can anyone enlighten me whats holding this back?
Noone but darix won't touch it - and darix will have to explain his reasons
This is becoming ridiculous now - both the bug report and this SR have been ignored by the maintainers for 2 months ...
@coolo: So, as @darix apparently does not have any objections, can you please accept the SR?
de acuerdo
This comment has been deleted
Obviously @mschnitzer is not reviewing this, so I wonder why this package is assigned to him?
@darix - I think I answered your question, is anything missing? Otherwise, at least a "I am busy doing more important stuff" would be appreciated.
Sorry, I was away since end of November till today. I'm just seeing this right now. However, I'm not the maintainer of ruby2.6. I once packaged ruby2.6 together with darix, but I clearly don't have the experience to judge whether these changes are ok or not. I will remove myself as a maintainer - it probably has been set by accident. So @darix are you taking care of it?
@mschnitzer: review reminder