Request 814839 (revoked)

Overview

Request 814839 revoked

ARM Coresight technology provides features to allow execution trace collection for off-line analysis. libopencsd provides an API for decoding ARM Coresight trace streams. Perf tool is used to control and collect trace data. Once trace data has been collected, perf tool linked with libopencsd can be used to decode trace streams off-line.

Add libopencsd to Factory so that perf tool can be linked against it.

Created by ykaukab almost 4 years ago
In state revoked
Open review for licensedigger
Open review for opensuse-review-team
Open review for factory-staging

Submit libopencsd

Comments for request 814839 4

Jan Engelhardt (jengelh) - almost 4 years ago

reviewer source maintainer

The upstream project's name is "openscd" not "libopenscd", so that is what the "Name:" field should have as well (just like the specfile copyright header already has in place). https://en.opensuse.org/openSUSE:Package_naming_guidelines

No (R) or (TM) tags. https://en.opensuse.org/openSUSE:Package_description_guidelines

+Requires: libstdc++-devel should probably go away, because one can use other C++ implementations (like clang's).

Aaron Puchert (aaronpuchert) - almost 4 years ago

because one can use other C++ implementations

If you're linking a library that links with libstdc++, then you better not link with libc++. So you kind of have to use libstdc++.

If you use C++, that is. As far as I can see, this is a C API. So you don't need any C++ standard library at all.

Dominique Leuenberger (dimstar) - almost 4 years ago

reviewer

additional to what @jengelh already said:

75+%files -n libopencsd%{libnum}
76+%license LICENSE
77+%{_bindir}/trc_pkt_lister
78+%{_libdir}/libopencsd.so.%{version}
79+%{_libdir}/libopencsd.so.%{libnum}

This is a shared library packaging policy violation. the binary must not be part of the library package, as it makes it impossible to install two versions of the library (file conflicts)