Overview

Request 834744 revoked

- libmicrohttpd 0.9.71:
* Fix buffer overflow issue in URL parser [boo#1173718]
* Fixed PostProcessor bug
* Documentation and example fixes



Dominique Leuenberger's avatar

pcp fails to build with this version microhttpd:

[  501s] g++ -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type  -g -fcommon -fPIC -fno-strict-aliasing -D_GNU_SOURCE  -Wall -O2 -g -DPCP_VERSION=\"4.3.4\" -I./src/include -I./src/include/pcp -fPIC -fno-strict-aliasing -D_GNU_SOURCE  -Wall -O2 -g -DPCP_VERSION=\"4.3.4\" -I../src/include -I../src/include/pcp -fPIC -fno-strict-aliasing -D_GNU_SOURCE -I/usr/include/p11-kit-1  -Wextra -fPIE -DHAVE_CAIRO -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/uuid -I/usr/include/libpng16  -DHAVE_ZLIB  -DHAVE_GRAPHITE -Wall -O2 -g -DPCP_VERSION=\"4.3.4\" -I../../src/include -I../../src/include/pcp -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type  -g -fcommon -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type  -g -fcommon -c main.cxx -o main.o
[  501s] main.cxx: In function 'int mhd_respond(void*, MHD_Connection*, const char*, const char*, const char*, const char*, size_t*, void**)':
[  501s] main.cxx:188:75: error: invalid conversion from 'int (*)(void*, MHD_ValueKind, const char*, const char*, const char*, const char*, const char*, uint64_t, size_t)' {aka 'int (*)(void*, MHD_ValueKind, const char*, const char*, const char*, const char*, const char*, long unsigned int, long unsigned int)'} to 'MHD_PostDataIterator' {aka 'MHD_Result (*)(void*, MHD_ValueKind, const char*, const char*, const char*, const char*, const char*, long unsigned int, long unsigned int)'} [-fpermissive]
[  501s]   188 |                 mhd_cc->pp = MHD_create_post_processor (connection, 1024, &mhd_post_iterator,
[  501s]       |                                                                           ^~~~~~~~~~~~~~~~~~
[  501s]       |                                                                           |
[  501s]       |                                                                           int (*)(void*, MHD_ValueKind, const char*, const char*, const char*, const char*, const char*, uint64_t, size_t) {aka int (*)(void*, MHD_ValueKind, const char*, const char*, const char*, const char*, const char*, long unsigned int, long unsigned int)}
[  501s] In file included from pmwebapi.h:36,
[  501s]                  from main.cxx:18:
[  501s] /usr/include/microhttpd.h:3465:49: note:   initializing argument 3 of 'MHD_PostProcessor* MHD_create_post_processor(MHD_Connection*, size_t, MHD_PostDataIterator, void*)'
[  501s]  3465 |                            MHD_PostDataIterator iter, void *iter_cls);
[  501s]       |                            ~~~~~~~~~~~~~~~~~~~~~^~~~

CC @msmeissn and @dmdiss and @kwk


Dominique Leuenberger's avatar

Waiting for pcp fix


Dominique Leuenberger's avatar

Also affects libyui-rest-api

[   21s] /home/abuild/rpmbuild/BUILD/libyui-rest-api-0.5.4/src/YHttpServer.cc: In function 'MHD_Result requestHandler(void*, MHD_Connection*, const char*, const char*, const char*, const char*, size_t*, void**)':
[   21s] /home/abuild/rpmbuild/BUILD/libyui-rest-api-0.5.4/src/YHttpServer.cc:237:50: error: invalid conversion from 'int' to 'MHD_Result' [-fpermissive]
[   21s]   237 |         return MHD_queue_basic_auth_fail_response(connection, "libyui realm", response);

Dominique Leuenberger's avatar

Unignored: returned to active backlog.

Request History
Dirk Mueller's avatar

dirkmueller created request

- libmicrohttpd 0.9.71:
* Fix buffer overflow issue in URL parser [boo#1173718]
* Fixed PostProcessor bug
* Documentation and example fixes


Saul Goodman's avatar

licensedigger accepted review

ok


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:E as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:E"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:E"


Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Being evaluated by group "factory-staging"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Unstaged from project "openSUSE:Factory:Staging:E"


Richard Brown's avatar

RBrownSUSE set openSUSE:Factory:Staging:I as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:I"


Richard Brown's avatar

RBrownSUSE accepted review

Picked "openSUSE:Factory:Staging:I"


Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Being evaluated by group "factory-staging"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Unstaged from project "openSUSE:Factory:Staging:I"


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:M as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:M"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:M"


Dominique Leuenberger's avatar

dimstar declined review

Breaks pcp and libyui-rest-api - we need
https://git.gnunet.org/libmicrohttpd.git/commit/?id=860b42e9180da4dcd7e8690a3fcdb4e37e5772c5


Dominique Leuenberger's avatar

dimstar declined request

Breaks pcp and libyui-rest-api - we need
https://git.gnunet.org/libmicrohttpd.git/commit/?id=860b42e9180da4dcd7e8690a3fcdb4e37e5772c5


Dominique Leuenberger's avatar

dimstar_suse reopened request

Reopened via staging workflow.


Dominique Leuenberger's avatar

dimstar_suse added factory-staging as a reviewer

Being evaluated by group "factory-staging"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Unstaged from project "openSUSE:Factory:Staging:M"


Dominique Leuenberger's avatar

dimstar_suse declined request

Declined via staging workflow.


Dirk Mueller's avatar

dirkmueller revoked request

openSUSE Build Service is sponsored by