Overview

Request 836059 superseded

ditto

Loading...

Dominique Leuenberger's avatar
31+mkdir -p %{buildroot}%{_prefix}%{_sysconfdir}/pam.d
32+cat > %{buildroot}%{_prefix}%{_sysconfdir}/pam.d/physlock <<-'EOF'

That took me two seconds to understand why this looks so weird :)

you likely want to use distconfdir here.

On old systems, you have this defined to be /etc, on newer systems it is pre-defined to be /usr/etc.

The way you package it now, it has potential to fail when distconfdir is not defined, as then you create the files in prefix/sysconfdir (aka /usr/etc) but in the files section you then use distconfdir, which has been redefined to sysconfdir, aka /etc

Request History
Dr. Werner Fink's avatar

WernerFink created request

ditto


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar_suse added as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:109"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:109"


Dr. Werner Fink's avatar

WernerFink superseded request

superseded by 836091

openSUSE Build Service is sponsored by