(not closely inspected this yet, so this is thinking out loud; will look more closely in a few hours) does it need really need poetry? I guess it is the declared wheel builder? ;/

Replacing dephell with poetry is a step backwards IMO, but I cant ignore the fact that getting dephell working was also a mess, and this is neater. poetry and pipenv are more development tools, and poetry hasnt yet really stabilised wrt functionality, despite the v1.0 which should mean the api/cli are stable.

At least please change changelog "Kill dephell dependency" to "Replace build dependency dephell with poetry" , as this isnt merely dropping one helper, it was replacing one helper with another one.

Also it would be appreciated to create an issue/PR upstream to get the sdist populated with tests, so we can switch to using PyPI releases.

I'm less concerned about reproducible builds for this package, as it will have fewer users, fewer new releases, etc, etc, and im happy to monitor this package for a while after merging to see if any reproducible build problems arise (I'm guessing I'll notice them as it will trigger many rebuilds in home:jayvdb:django).

John Vandenberg (jayvdb) - over 3 years ago

target maintainer

Created issue https://github.com/zostera/django-bootstrap3/issues/492

Benjamin Greiner (bnavigator) - over 3 years ago

author

I disagree.

• poetry is up- stream's declared PEP517 backend. The use of dephell was only introduced as openSUSE specific packaging workaround and is not supported by upstream. I am sure you had noble intentions when creating the %dephell_gensetupmacro. But it creates more problems than it solves.

Specifically, dephell is not compatible with newest pip and python-bowler, so it blocks the update of a lot of packages right now: https://build.opensuse.org/package/show/openSUSE:Factory:Staging:H/python-dephell:test https://build.opensuse.org/package/show/home:mcalabkova:branches:devel:languages:python:pytest/python-dephell Apparently @mcalabkova tries to fix it, but did not succeed yet.

Upstream dephell has not responded on bug reports and pull request for months. https://github.com/dephell/dephell/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc

Dephell itself brings a whole hell of dependencies and does not handle the input files correctly gh#dephell/dephell#347

https://github.com/python-poetry/poetry/issues/1645#issuecomment-715252659

django-bootstrap3 could move to poetry-core at least. But nothing forces them to require setuptools. In fact relying on them to do the conversion in the sdist creation is just the same step as using poetry as backend directly. In contrast to relying on dephell, we are using an upstream supported packaging approach then.

About reproducibility: %pyproject_install recompiles everything as soon as the macros are updated, before that, no compilation at all is performed:

gh#openSUSE/python-rpm-macros#37 gh#openSUSE/python-rpm-macros#60

---

John Vandenberg (jayvdb) - over 3 years ago

target maintainer

I'll take a look at the dephell bugs. I've been fixing a lot of them, so I am biased, and wont bother arguing. p.s. i dont believe I created the macro. I only used dephell on a few packages I am directly involved in; someone else spread it further , and then I needed to fix the macro .

Repo was moved to https://github.com/zostera/django-bootstrap3