This request is superseded by
request 845767
(Show diff)
Overview
Request 845051 superseded
Dependency for new package meshlab (currently adi:19)
- Created by StefanBruens
- In state superseded
- Superseded by 845767
-
Open review for
opensuse-review-team
- Open review for openSUSE:Factory:Staging:adi:23
Loading...
Request History
StefanBruens created request
Dependency for new package meshlab (currently adi:19)
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar_suse added openSUSE:Factory:Staging:adi:23 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:23"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:23"
licensedigger accepted review
ok
@dimstar - I think this slipped through.
Why do you think so? I just did not yet invest the time to review it; from first look, I'd say the assumption of %major being the soversion is just wrong - so wrong :)
ABI being based on version is doomed to break
echo "set_target_properties(levmar PROPERTIES SOVERSION %{major})" >> CMakeLists.txt
yes, exactly that part - it assumes that the version has any relevance to the ABI version of the library.