Overview
Request 845767 accepted
New package, dep for meshlab
Bump revision, fixes build for Leap/SLE 15.x
- Created by StefanBruens
- In state accepted
- Supersedes 845051
@dimstar - I think this slipped through.
Why do you think so? I just did not yet invest the time to review it; from first look, I'd say the assumption of %major being the soversion is just wrong - so wrong :)
ABI being based on version is doomed to break
echo "set_target_properties(levmar PROPERTIES SOVERSION %{major})" >> CMakeLists.txt
yes, exactly that part - it assumes that the version has any relevance to the ABI version of the library.
Request History
StefanBruens created request
New package, dep for meshlab
Bump revision, fixes build for Leap/SLE 15.x
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
dimstar_suse added as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:23"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:23"
licensedigger accepted review
ok
dimstar accepted review
Nobody vetos, so then…
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:23 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:23 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:23 got accepted.
@jengelh
What do you think about
88+echo "set_target_properties(levmar PROPERTIES SOVERSION %{major})" >> CMakeLists.txtSure, better than nothing - but imho we add a soversion based on he package version which most likely bares no relevance to ABI stability (otherwise upstream would likely care a little bit for it)