Overview

Request 855367 revoked

- Fix build
- add fix_multiple_definition_errors.patch from upstream

Loading...

John Paul Adrian Glaubitz's avatar

Why not mention what actually fixed the build? Was it adding the missing build dependency?


Christophe Giboudeaux's avatar

-License: GPL-2.0-or-later

+License: GPL-2.0+

This change is probably not wanted. run spec-cleaner


David Haller's avatar

argh SPDX changed that since last I looked. Well, easy to fix and shouldn't be a blocker.


David Haller's avatar

Both that dep on gdk_pixbuf_xlib and the new patch that dimstar found were needed. The rest is cosmetics.


Christophe Giboudeaux's avatar

there's a lot of obsolete stuff in the spec that could be removed later

  • empty conditions (%if 0%{?suse_version} > 1230)

  • obsolete version checks (1210, 1220...)

  • old macros that don't do anything since years (%install_info_prereq, %desktop_database_post, %icon_theme_cache_postun, %install_info_delete)

  • %{_datadir}/kde4 shall be removed for anything > leap 15.2



Philipp Seiler's avatar

@dnh Could you supersed the request with a new working one?


David Haller's avatar

glaubitz submitted the conflicting sr https://build.opensuse.org/request/show/857849 (note the date of that sr vs. mine! and the content!). That sr was accepted, nicely sabotaging my sr and mine wasn't even declined or anything. AFAIR that was all AFTER I commented here (4 vs. 5 months ago supports as of now that notion). And as I neither use a current SUSE nor sawfish, go and do all that yourselves. You still have my input. You could have just used it, improved it and all would have been happy, but nooo, someone had to apply a conflicting sr. So, I'm out. I do not care anymore.

Request History
David Haller's avatar

dnh created request

- Fix build
- add fix_multiple_definition_errors.patch from upstream


David Haller's avatar

dnh revoked request

openSUSE Build Service is sponsored by