Request 867989 (accepted)

Overview

Request 867989 accepted

- Update to 4.0.2
+ What's New
* fixing the long-standing issue where Firefox popups would sometimes show up
in the wrong place on multi-monitor setups
* Initial implementation of _NET_FRAME_EXTENTS
* Fix potential livelock in do_timer_set
+ Docs
Add more docs to cfg_notion.lua
- Using $PREFIX, $ETCDIR, ... during build helps notion to find default config if there is
no user-provided config and puts correct absolute filenames in the manpage

Created by xha over 3 years ago
In state accepted
Package maintainer: avindra

Submit notion

Comments for request 867989 7

Avindra Goolcharan (avindra) - over 3 years ago

target maintainer

-%make_build
+%make_build \
+    PREFIX="%{_prefix}" \
+    ETCDIR="%{_sysconfdir}/%{name}" \
+    LIBDIR="%{_libdir}" \
+    DOCDIR="%{_docdir}/%{name}"

Is this needed to build?

Xaver Hellauer (xha) - over 3 years ago

author source maintainer

At least PREFIX and ETCDIR are needed, I'm not sure about the other two. Rationale:

Without PREFIX and ETCDIR, notion does not know where to look for the default config if there is no user-provided config.
Without PREFIX, the man-page shows directories for some files, like:

FILES AND DIRECTORIES
       /usr/local/etc/notion/cfg_notion.lua
              System default main configuration files

Avindra Goolcharan (avindra) - over 3 years ago

target maintainer

Thanks. I left it in for the %install section. Just a heads up, its usually safe to omit these in the %build section. It generally has has no effect during the build phase. Changed here:

https://build.opensuse.org/package/rdiff/X11:windowmanagers/notion?linkrev=base&rev=12

Avindra Goolcharan (avindra) - over 3 years ago

target maintainer

Follow-up: just saw your note:

Using $PREFIX, $ETCDIR, ... during build helps notion to find default config if there is
  no user-provided config and puts correct absolute filenames in the manpage

I restored it here:

https://build.opensuse.org/package/rdiff/X11:windowmanagers/notion?linkrev=base&rev=14

Avindra Goolcharan (avindra) - over 3 years ago

target maintainer

2 comments regarding the removal of notion-makefile.patch:

Removed patches should be mentioned in .changes
The patch was supplying OPTFLAGS to inject the default build flags. Removing the patch means the optflags aren't getting passed anymore:

--CFLAGS=-Os $(WARN) $(DEFINES) $(INCLUDES) $(EXTRA_INCLUDES)
-+OPTFLAGS=-Os
-+CFLAGS=$(OPTFLAGS) $(WARN) $(DEFINES) $(INCLUDES) $(EXTRA_INCLUDES)

Xaver Hellauer (xha) - over 3 years ago

author source maintainer

I'm sorry, I was under the impression that this patch was not needed anymore since it is not listed in the .spec file, so I removed it when I tried to figure out what makes the config fallback fail; I should've mentioned this in the changelog. Is it still needed?

Avindra Goolcharan (avindra) - over 3 years ago

target maintainer

Thanks @xha no problem. I looked into it and the patch step was removed by another user in 2014 and not documented:

https://build.opensuse.org/package/rdiff/X11:windowmanagers/notion?linkrev=base&rev=4

Wed Jul  9 03:56:54 UTC 2014 - jsegitz@suse.com

I will accept your patch (thanks for submitting) and address the patch notes. It may need rebasing too, which I'll take care of.

Request History

xha created request over 3 years ago

avindra accepted request over 3 years ago

Thanks. Cleaning up patch issue in the repo shortly.

Places

Overview