Thanks for review!

We want to install signkey package by pattern. So I created a independent package to help user to enroll key to MOK. It's only for openSUSE KMP on OBS.

Thanks for your review!

. The check in %build shouldn't be needed. If the file is missing, it's going to break anyway

OK! I will remove the check.

. Calling rpm in scriptlets might deadlock

I will use "ls" to grab the certificate file name.

. Scriptlets are also called on upgrades, but then most of them shouldn't do anything unless the file changes

This RPM will not be rebuilt unless the openSUSE signkey be changed on OBS. When this RPM be upgraded, it means that the openSUSE signkey also be updated.

. Most of the scriptlets can be simplified by moving them inside if command -v mokutil

OK, I will move them inside ' if command -v mokutil '.

Fabian Vogt (favogt) - about 3 years ago

This RPM will not be rebuilt unless the openSUSE signkey be changed on OBS. When this RPM be upgraded, it means that the openSUSE signkey also be updated.

There will be forced rebuilds without source changes, so the package has to take that into account.

Thanks! I will change the name.