Overview

Request 893745 revoked

Removed unneeded libmlt-devel build requirement ready for the libmlt6 package.

Loading...

Wolfgang Bauer's avatar

I think this change is fine.
kdenlive (still) does have these anyway:
BuildRequires: pkgconfig(mlt++) >= %{mlt_version}
BuildRequires: pkgconfig(mlt-framework) >= %{mlt_version}

Seems that libmlt-devel was just superfluous...



Wolfgang Bauer's avatar

May I ask why you revoked this?
As I wrote, I think this change makes sense, I just wanted to give other maintainers a chance to comment.

And without it, both libmlt6-devel and libmlt(7)-devel will be pulled in (once the latter is in Factory), which shouldn't cause problems I suppose but is totally unnecessary too IMHO.


Dave Plater's avatar
author source maintainer

a series of events that occurred at the time of the libmlt saga have led me to believe that it would have been declined by the maintainer anyway. Although I made alios maintainer of libmlt6 I had to submit it myself.


Wolfgang Bauer's avatar

It was originally declined because of the libmlt "dilemma" AIUI.
But that's resolved now it seems with the submission of libmlt6 to Factory.

I'd say please reopen this, as mentioned I think we should do this change anyway (even regardless of the libmlt situation).

Thank you.


Wolfgang Bauer's avatar

And TBH, this SR originally confused me as well. I thought that kdenlive of course should need libmlt-devel. (so I can understand it was declined without comment)

But then I noticed that it's actually not needed due to the other BuildRequires, that's why I wrote my first comment.


Wolfgang Bauer's avatar

"that it would have been declined by the maintainer anyway"

Oh, and another thing: I am a maintainer (of kdenlive) as well. There is not just one.
So I can accept this SR, but I cannot do it now as you revoked it.


Christophe Giboudeaux's avatar

This BuildRequires is a good way to check if the provides/obsoletes are correct (and they're not, the libmlt-devel package definition is in a %if 0 block)


Wolfgang Bauer's avatar

But libmlt(7)-devel doesn't provide "pkgconfig(mlt++)" or "pkgconfig(mlt-framework)" anyway.

And the only provides/obsoletes I see are for kdenlive5, which don't depend on libmlt either.


Wolfgang Bauer's avatar

Also: "the libmlt-devel package definition is in a %if 0 block"

What are you talking about here?
I don't find that in kdenlive.spec... :-/


Wolfgang Bauer's avatar

Ah, that's probably about libmlt6 then. ;-)
AFAICS, the package definition actually is outside the "%if 0" block.

But I still don't see at all how it would be related to this change.


Wolfgang Bauer's avatar

And the two libmlt?-devel packages don't have any provides/obsoletes either AFAICS (so I don't see why that should be checked), and I don't see why they should have, considering that they can co-exist.


Wolfgang Bauer's avatar

@dplater: I understand that you don't want to be part of this disussion.
I created a new SR now with the same change (SR#895324), but still feel free to reopen yours if you want (I will revoke mine then).


Wolfgang Bauer's avatar

Ok, SR#895324 was accepted and forwarded to Factory.


Wolfgang Bauer's avatar

So in the end there was just some misunderstanding here.

@dplater: Let me say thank you for all the great work you did over the years, and still do.
I think all openSUSE users (including me) do owe you a lot!
openSUSE wouldn't be what it is without you.

Request History
Dave Plater's avatar

plater created request

Removed unneeded libmlt-devel build requirement ready for the libmlt6 package.


Christophe Giboudeaux's avatar

cgiboudeaux declined request


Dave Plater's avatar

plater reopened request

I'll put libmlt6 into multimedia:libs and luigi can do the rest.


Dave Plater's avatar

plater revoked request

openSUSE Build Service is sponsored by