Request 918836 (accepted)

Overview

Request 918836 accepted

- Add ncurses patch 20210911
+ adjust ifdef in test_opaque.c to fix build with ncurses 5.7
+ add testing note for xterm-{hp|sco|sun} -TD
+ corrected description for ansi.sys-old -TD
+ add xterm+nopcfkeys, to fill in keys for xterm-hp, xterm-sun -TD
+ use hp+arrows in a few places -TD
+ use hp+pfk-cr in a few places -TD
- Correct offsets of patch ncurses-6.2.dif

- Add ncurses patch 20210905
+ correct logic in filtering of redefinitions (report by Sven Joachim,
cf: 20210828).
- Add ncurses patch 20210904
+ modify linux3.0 entry to reflect default mapping of shift-tab by
kbd 1.14 (report by Jan Engelhardt) -TD
+ add historical note to tput, curses-terminfo and curses-color
manpages based on source-code for SVr2, SVr3 and SVr4.
+ minor grammatical fixes for "it's" vs "its" (report by Nick Black).
+ amend fix for --disable-root-environ (report by Arnav Singh).
+ build-fix for compiling link_test
+ drop symbols GCC_PRINTF and GCC_SCANF from curses.h.in, to simplify
use (Debian #993179).
- Add ncurses patch 20210828
+ correct reversed check for --disable-root-environ (report/analysis
by Arnav Singh, cf: 20210626).
+ apply gcc format attribute to prototypes which use a va_list
parameter rather than a "..." variable-length parameter list
(prompted by discussion in a tmux pull-request).
+ modify configure scripts to filter out redefinitions of _XOPEN_SOURCE,
e.g., for NetBSD which generally supports 500, but 600 is needed for

Created by WernerFink almost 3 years ago
In state accepted

Submit ncurses

Comments for request 918836 11

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer

vim test fails sounds somewhat related:

[  970s] Failures: 
[  970s]    From test_termcodes.vim:
[  970s]    Found errors in Test_modifyOtherKeys_shift_tab():
[  970s]    command line..script /home/abuild/rpmbuild/BUILD/vim-8.2.3360/src/testdir/runtest.vim[486]..function RunTheTest[44]..Test_modifyOtherKeys_shift_tab line 9: Expected '<S-Tab>' but got '[Z'
[  970s] 
[  970s] TEST FAILURE

Dr. Werner Fink (WernerFink) - over 2 years ago

author source maintainer

Related to what ... '<S-Tab>' is symbol string whereas [Z is an escape sequence which might represents this symbol or an other symbol. The vim symbols are defined in vim code or vimrc an mapped to a escape seqence whereas the ncurses terminfo database only describes the used escape seqence of a terminal (the only exception is the mapping of the DEL key for XTerm as xterm decides on the setting in the terminfo data base for TERM=xterm what escape sequences has to be used ... was long time ago a patch from mine and is meanwhile a long time upstream in Xterm)

Dr. Werner Fink (WernerFink) - over 2 years ago

author source maintainer

Example mapping can be found here /usr/share/vim/vim82/suse.vimrc ... here yu can see the <ESC> which is th esymbol for a real escape sign (which I had used in past for vimrc but replaced it)

Dominique Leuenberger (dimstar) - over 2 years ago

reviewer

https://build.opensuse.org/package/show/openSUSE:Factory:Staging:N/vim

There are currently three packages in this staging that are not yet in other stagigns and/or the product, so any of those three being relevant to the newly seen/reproducible build fali is highly likely.

The three packages are:

elfutiils (hardened debuginfod service, unlikely to have such an impact)
libatomic_ops (from my queries, this one should not impact vim's build env)
ncurses

Dr. Werner Fink (WernerFink) - over 2 years ago

author source maintainer

For xterm nor xterm-256color I do not found any difference in the terminfo description with this submit ...

noether:/ # cmp -l /tmp/xterm-extern.txt /tmp/xterm.txt
noether:/ # cmp -l /tmp/xterm-256color-extern.txt /tmp/xterm-256color.txt
noether:/ #

do you know which terminal type is affected?

Dr. Werner Fink (WernerFink) - over 2 years ago

author source maintainer

How this is meant to work:

" Whether Shift-Tab sends "ESC [ Z" or "ESC [ 27 ; 2 ; 9 ~" is unpredictable,
" both should work.
func Test_modifyOtherKeys_shift_tab()
  set timeoutlen=10

  call setline(1, '')
  call feedkeys("a\<C-K>" .. GetEscCodeCSI27("\t", '2') .. "\<Esc>", 'Lx!')
  eval getline(1)->assert_equal('<S-Tab>')

  call setline(1, '')
  call feedkeys("a\<C-K>\<Esc>[Z\<Esc>", 'Lx!')
  eval getline(1)->assert_equal('<S-Tab>')

  set timeoutlen&
  bwipe!
endfunc

Dr. Werner Fink (WernerFink) - over 2 years ago

author source maintainer

Just run the test within an xterm with

cd src/testdir
make

and got

Test results:

Skipped:
        Test_term_mouse_middle_click(): clipboard_working feature missing
        Test_term_mouse_middle_click_in_cmdline_to_paste(): clipboard_working feature missing
        Test_term_mouse_middle_click_insert_mode(): clipboard_working feature missing

-------------------------------
Executed:    58 Tests
 Skipped:     3 Tests
  Failed:     0 Tests

ALL DONE

... ah ... within %check there is

export TERM=linux

how this is supposed to work without an linux terminal surrounding?

Dr. Werner Fink (WernerFink) - over 2 years ago

author source maintainer

Indeed

abuild@noether:~/rpmbuild/BUILD/vim-8.2.3408/src/testdir> diff -up /tmp/linux.txt /tmp/linux-extern.txt
--- /tmp/linux.txt      2021-09-17 09:49:40.743792770 +0000
+++ /tmp/linux-extern.txt       2021-09-17 09:49:20.275513157 +0000
@@ -54,7 +54,7 @@ linux|linux console,
        initc=\E]P%p1%x%p2%{255}%*%{1000}%/%02x%p3%{255}%*%{1000}%/%02x%p4%{255}%*%{1000}%/%02x,
        kb2=\E[G,
        kbs=^?,
-       kcbt=\E^I,
+       kcbt=\E[Z,
        kcub1=\E[D,
        kcud1=\E[B,
        kcuf1=\E[C,

and indeed the kcbt=\E^I is correct ...

- Add ncurses patch 20210904
  + modify linux3.0 entry to reflect default mapping of shift-tab by
    kbd 1.14 (report by Jan Engelhardt) -TD

Dr. Werner Fink (WernerFink) - over 2 years ago

author source maintainer

Just do

echo "Ctrl-V-Shift-Tab" | od -tx1

on linux console and the same within an xterm ... that is typing first echo " then press Ctrl-V followed by Shift-Tab and close the " and append | od -tx1 ... finallly press Enter