This request is superseded by
request 962002
(Show diff)
Overview
Request 949758 superseded
- remove PS1-completion-boo903362.patch as it breaks on non-bash
shells and the original problem in
bsc#903362#c9 does not occur anymore
- Created by dirkmueller
- In state superseded
- Superseded by 962002
Loading...
Request History
dirkmueller created request
- remove PS1-completion-boo903362.patch as it breaks on non-bash
shells and the original problem in
bsc#903362#c9 does not occur anymore
dirkmueller superseded request
superseded by 962002
Can you please explain which none bash bourne shell does source bash_completion.sh and how this happens ? Bash completion is not very usefull for other bourne shells due missing builtin functions like compgen
Mon Nov 17 12:46:11 UTC 2014 - werner@suse.de - Add patch PS1-completion-boo903362.patch to avoid trouble if restricted characters of the shell are used in PS1 like exclamation mark (boo#903362).
and I can reproduce this with bash 5.0.11 as well as with 5.1.12
boole:(/dev/pts/11) 497 : find ibash: fc: no command found
noether:(/dev/pts/13) 498 : find inbash: fc: no command found
iirc this was sourced via /etc/profile which for example dash or busybox-sh are sourcing on interactive shells. and the if condition is exactly checking whether it is a bash environment or not, but your patch was changing the if condition to use bash constructs, so it failed on anything other than bash, breaking the whole purpose of the if condition to begin with
Ah ... with latest bash 5.1.16
then maybe change the line
Requires: bash
to
Requires: bash >= 5.1.16
@WernerFink, @pbleser, @poeml: review reminder