Request 952842 (accepted)

This request supersedes: request 952763 (Show diff)

Overview

Request 952842 accepted

- Update to 2.9.0b
+ The project is now under the MIT license
+ FTPS: support implicit TLS (new protocol: FTPSi)
+ support MLSD
+ fixed IPv6 support
+ new option 'ip_version' (any/ipv4/ipv6) [default=any]
+ fully implement rfc2428 (EPSV, EPRT)
+ automatically determine when to use PRET (these features
are only used if the server explicitly supports them through
the FEAT response)
+ fix crash with file transfers in active mode
+ new option: gFTP->Preferences->Network -> IP Protocol

Created by Kieltux over 2 years ago
In state accepted
Supersedes 952763

Submit gftp

Comments for request 952842 0
Comments for request 952763 4

Luciano Santos (luc14n0) - over 2 years ago

reviewer target maintainer

First of all, thank you @Kieltux for taking the time to update this package.

Now, some pointers:

  +Tue Feb  8 16:32:09 UTC 2022 - Carsten Ziepke <kieltux@gmail.com>
  +
  +- Removed gzip as BuildRequires because OBS is handling this choice
  +  internally and must never be handled in spec files
  +
  +-------------------------------------------------------------------
  +Tue Feb  8 06:15:49 UTC 2022 - Carsten Ziepke <kieltux@gmail.com>
  +
  +- Add gzip as BuildRequires, because have choice for gzip needed
  +  by rpm-build: gzip zstd-gzip
  +
  +-------------------------------------------------------------------

There's no need for those additions in the changes file. Since your 2.9.0b version update hasn't been merged yet in GNOME:Apps, it's just unnecessary clutter.

  +- Update to 2.9.0b
  +  - The project is now under the MIT license
  +  - FTPS: support implicit TLS (new protocol: FTPSi)
  ...

Please, use + here for first level indentation to keep consistency. We never know if someday someone will need to use some scrip to parse the file. They should be:

  - Update to 2.9.0b
    + The project is now under the MIT license
    + FTPS: support implicit TLS (new protocol: FTPSi)
    ...

And for future reference, next time you need to change something in a package while updating it you can do it like this, for example:

  -------------------------------------------------------------------
  Tue Feb  8 05:58:22 UTC 2022 - Carsten Ziepke <kieltux@gmail.com>

  - Update to 2.9.0b
    + The project is now under the MIT license;
    + FTPS: support implicit TLS (new protocol: FTPSi);
    + Support MLSD;
    + Fixed IPv6 support;
    + New option 'ip_version' (any/ipv4/ipv6) [default=any];
    + Fully implement rfc2428 (EPSV, EPRT);
    + Automatically determine when to use PRET (these features
      are only used if the server explicitly supports them through
      the FEAT response);
    + Fix crash with file transfers in active mode;
    + New option: gFTP->Preferences->Network -> IP Protocol.
  - Add foo as BuildRequires because it's needed now. Without it the
    build fails.

  -------------------------------------------------------------------

You just add the packaging changes at the bottom, right after the upstream update changes 8^D