Overview

Request 954323 accepted

- Fix changelog and permissions
- (bsc#1185074) /var/run in /usr/lib/tmpfiles.d/dovecot.conf is
deprecated, please use /run instead
- Refreshed spec-file via spec-cleaner and manual optimization.
* Removed file dovecot.init (droped SystemV support).
* Added parameter -p to all install command in spec-file.
* Added %{name} macro wherever possible.
- Check first if they exist before creating user and group accounts
- Use macro for systemd-tmpfiles call
- Pre-Require shadow if we use it in %pre
- Remove unused systemd requires/defines.
- removal of SuSEfirewall2 service, since SuSEfirewall2 has been replaced by
firewalld, see [1].
[1]: https://lists.opensuse.org/opensuse-factory/2019-01/msg00490.html
- Add information about the interaction with Apparmor to README.SUSE
- bump recommends to 2.3
- copy example config from /usr/share/dovecot/example-config/
instead of the documentation directory. (boo#1070871)
- bump to dovecot 2.3
- updated README.SUSE:
Remove all references /etc/ssl/certs/. It should not be used
anymore. (boo #932386)
Please make sure you read README.SUSE after installing this
update.
- fix bashisms in pre script
- add reload support to the dovecot service file
- also track the config files from the sieve support in the %ghost
- make the /etc/dovecot handling consistent between dovecot and
dovecotXY. both now use:
%dir /etc/dovecot
%ghost %config(noreplace) /etc/dovecot/*
- copy the correct file as init script in the non systemd case
- remove %buildroot from %pre script just in case we uncomment that
part at some point
- only have %post in the systemd case
- we dont need a dovecot implementation at build time just at
install time. add BuildIgnore to get around the loop.
- remove triggers again. when we handle the dovecot update problems
by manually stopping in %pre and manually starting up again in
%postun we dont need them anymore.
- as we cant use service_del_preun we should still check if it is
the last package that we install otherwise we kill it
unconditionally
- no longer restart the socket activation. this seems to kill the
dovecot.
- move ldconfig to the versioned packages
- own the shared var directories.
- kick out the triggerin script as we dont need it.
- restart dovecot also when the module packages are updated
- added trigger scripts
- make the dovecot implementation a prereq
- start an unversioned wrapper package again

Loading...

Dominique Leuenberger's avatar

157+/usr/lib/tmpfiles.d/%{name}.conf

this was also something listed in the previous decline message - use %_tmpfilesdir


Илья Индиго's avatar

Please explain why the %{install} and %{ln_s} macros are used instead of "install" and "ln -s"?


Dirk Stoecker's avatar

Ask the package maintainer about existing stuff. I'm only fixing the errors done in the updates.

Request History
Dirk Stoecker's avatar

dstoecker created request

- Fix changelog and permissions
- (bsc#1185074) /var/run in /usr/lib/tmpfiles.d/dovecot.conf is
deprecated, please use /run instead
- Refreshed spec-file via spec-cleaner and manual optimization.
* Removed file dovecot.init (droped SystemV support).
* Added parameter -p to all install command in spec-file.
* Added %{name} macro wherever possible.
- Check first if they exist before creating user and group accounts
- Use macro for systemd-tmpfiles call
- Pre-Require shadow if we use it in %pre
- Remove unused systemd requires/defines.
- removal of SuSEfirewall2 service, since SuSEfirewall2 has been replaced by
firewalld, see [1].
[1]: https://lists.opensuse.org/opensuse-factory/2019-01/msg00490.html
- Add information about the interaction with Apparmor to README.SUSE
- bump recommends to 2.3
- copy example config from /usr/share/dovecot/example-config/
instead of the documentation directory. (boo#1070871)
- bump to dovecot 2.3
- updated README.SUSE:
Remove all references /etc/ssl/certs/. It should not be used
anymore. (boo #932386)
Please make sure you read README.SUSE after installing this
update.
- fix bashisms in pre script
- add reload support to the dovecot service file
- also track the config files from the sieve support in the %ghost
- make the /etc/dovecot handling consistent between dovecot and
dovecotXY. both now use:
%dir /etc/dovecot
%ghost %config(noreplace) /etc/dovecot/*
- copy the correct file as init script in the non systemd case
- remove %buildroot from %pre script just in case we uncomment that
part at some point
- only have %post in the systemd case
- we dont need a dovecot implementation at build time just at
install time. add BuildIgnore to get around the loop.
- remove triggers again. when we handle the dovecot update problems
by manually stopping in %pre and manually starting up again in
%postun we dont need them anymore.
- as we cant use service_del_preun we should still check if it is
the last package that we install otherwise we kill it
unconditionally
- no longer restart the socket activation. this seems to kill the
dovecot.
- move ldconfig to the versioned packages
- own the shared var directories.
- kick out the triggerin script as we dont need it.
- restart dovecot also when the module packages are updated
- added trigger scripts
- make the dovecot implementation a prereq
- start an unversioned wrapper package again


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse added openSUSE:Factory:Staging:adi:34 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:34"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:34"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:adi:34 got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:adi:34 got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:adi:34 got accepted.

openSUSE Build Service is sponsored by