Overview

Request 967036 superseded

For 32-bit systems, rename tbb32.pc (default upstream for 32-bit) to tbb.pc (same as 64-bit) so that applications depending on tbb do not have to call different pkgconfig modules based on arch.

Loading...

Jan Engelhardt's avatar

affects all platforms with sizeof(void*)!=8, so %arm ppc too.


Atri Bhattacharya's avatar

Thanks for the careful review. I have now changed it to rename the tbb32.pc file whenever it is installed (rather than keeping track of multiple 32-bit archs by name).


Jan Engelhardt's avatar

You can't do this. pkgconfig(tbb) means that you can do pkg-config tbb --libs --cflags and get a result. But this is not what happens on i586, because there is no tbb.pc file. The root problem is that this project stupidly produces different .pc file names when there is absolutely no basis for it. (I am happy to argue in more detail on the matter.)

Rename the file, don't add manual Provides lines.


Atri Bhattacharya's avatar

Thanks, I did think it was weird that the project produces different .pc file names based on archs, but am worried if renaming might break something. For i586, we could install a symlink tbb.pc that points to tbb32.pc instead. Would that be okay, in your opinion?

THanks for the review.


Jan Engelhardt's avatar

I am not sure if symlinks are considered during /usr/lib/rpm/pkgconfigdeps.sh. A hardlink comes to mind.

The other thing is that anyone using PKG_CHECK_MODULES.. to test for tbb would also have to know about the tbb32 deviation, and that's just not scalable, so no one will be using tbb32.pc in practice.


Atri Bhattacharya's avatar

Yes, agree with you that renaming tbb32.pc to tbb.pc for 32-bit is probably the best way fwd. Superseded.

Request History
Atri Bhattacharya's avatar

badshah400 created request

For 32-bit systems, rename tbb32.pc (default upstream for 32-bit) to tbb.pc (same as 64-bit) so that applications depending on tbb do not have to call different pkgconfig modules based on arch.


openSUSE Build Service is sponsored by