Overview
Request 980448 superseded
mcomix was removed 3 years ago because it supported only python2. Now it supports python3.
- Created by gcomes.obs
- In state superseded
- Superseded by 980518
- Open review for openSUSE:Factory:Staging:adi:16
Request History
gcomes.obs created request
mcomix was removed 3 years ago because it supported only python2. Now it supports python3.
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar_suse added openSUSE:Factory:Staging:adi:16 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:16"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:16"
dimstar declined review
Please see the comments on https://build.opensuse.org/request/show/980448
There are a few things to correct
dimstar declined request
Please see the comments on https://build.opensuse.org/request/show/980448
There are a few things to correct
67+%doc
?30+BuildRequires: %{python_module setuptools}
No need to pull in all python versions...use python3-setuptools, same as for all the other BuildRequires
32+Requires: python3-gobject
As this is likely a GUI app, you most likely actually want python3-gobject-Gdk.
Also, if this uses object, it is possibly worthy to add
BuildRequires: gobject-introspection
- if needed, the package will receive sometypelib()
dependencies addedThe code does:
from gi.repository import GObject, Gdk, Gtk, GLib
so, yeah.. you do want python3-gobject-Gdk Requires and gobject-introspection Buildrequires.
80+%{_datadir}/appdata
you should not need to own the directory, only the files thereinAs thi si snot building any python module, these two lines are useless (this is a python-app, not a py module)