Overview
Request 980518 accepted
mcomix for python3. With spec file cleanup.
- Created by gcomes.obs
- In state accepted
- Supersedes 980448
30+BuildRequires: %{python_module setuptools}
No need to pull in all python versions...use python3-setuptools, same as for all the other BuildRequires
32+Requires: python3-gobject
As this is likely a GUI app, you most likely actually want python3-gobject-Gdk.
Also, if this uses object, it is possibly worthy to add BuildRequires: gobject-introspection
- if needed, the package will receive some typelib()
dependencies added
The code does: from gi.repository import GObject, Gdk, Gtk, GLib
so, yeah.. you do want python3-gobject-Gdk Requires and gobject-introspection Buildrequires.
80+%{_datadir}/appdata
you should not need to own the directory, only the files therein
19+%{?!python_module:%define python_module() python-%{**} python3-%{**}} 20+%define skip_python2 1
As thi si snot building any python module, these two lines are useless (this is a python-app, not a py module)
Request History
gcomes.obs created request
mcomix for python3. With spec file cleanup.
dimstar_suse added openSUSE:Factory:Staging:adi:16 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:16"
dimstar_suse accepted review
Picked "openSUSE:Factory:Staging:adi:16"
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto accepted review
Check script succeeded
licensedigger accepted review
ok
dimstar accepted review
dimstar_suse accepted review
Staging Project openSUSE:Factory:Staging:adi:16 got accepted.
dimstar_suse approved review
Staging Project openSUSE:Factory:Staging:adi:16 got accepted.
dimstar_suse accepted request
Staging Project openSUSE:Factory:Staging:adi:16 got accepted.