Overview

Request 980518 accepted

mcomix for python3. With spec file cleanup.

Loading...


Dominique Leuenberger's avatar

30+BuildRequires: %{python_module setuptools}

No need to pull in all python versions...use python3-setuptools, same as for all the other BuildRequires


Dominique Leuenberger's avatar

32+Requires: python3-gobject

As this is likely a GUI app, you most likely actually want python3-gobject-Gdk.

Also, if this uses object, it is possibly worthy to add BuildRequires: gobject-introspection - if needed, the package will receive some typelib() dependencies added


Dominique Leuenberger's avatar

The code does: from gi.repository import GObject, Gdk, Gtk, GLib

so, yeah.. you do want python3-gobject-Gdk Requires and gobject-introspection Buildrequires.


Dominique Leuenberger's avatar

80+%{_datadir}/appdata you should not need to own the directory, only the files therein


Dominique Leuenberger's avatar
19+%{?!python_module:%define python_module() python-%{**} python3-%{**}}
20+%define skip_python2 1

As thi si snot building any python module, these two lines are useless (this is a python-app, not a py module)

Request History
Giacomo Comes's avatar

gcomes.obs created request

mcomix for python3. With spec file cleanup.


Dominique Leuenberger's avatar

dimstar_suse added openSUSE:Factory:Staging:adi:16 as a reviewer

Being evaluated by staging project "openSUSE:Factory:Staging:adi:16"


Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked "openSUSE:Factory:Staging:adi:16"


Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources


Factory Auto's avatar

factory-auto accepted review

Check script succeeded


Saul Goodman's avatar

licensedigger accepted review

ok


Dominique Leuenberger's avatar

dimstar accepted review


Dominique Leuenberger's avatar

dimstar_suse accepted review

Staging Project openSUSE:Factory:Staging:adi:16 got accepted.


Dominique Leuenberger's avatar

dimstar_suse approved review

Staging Project openSUSE:Factory:Staging:adi:16 got accepted.


Dominique Leuenberger's avatar

dimstar_suse accepted request

Staging Project openSUSE:Factory:Staging:adi:16 got accepted.

openSUSE Build Service is sponsored by