Embed a build result badge whereever you need it. Select from
the options below and copy the result over to your README or on
your website, and enjoy it refresh automatically whenever the
build result changes.
I would rather not touch anything outside of this package that could affect other packages in this project.
But as I was able to fix something similar for 15.3 using BuildRequires in the spec file, this should be possible for fedora as well.
unresolvable: have choice for pkgconfig(jack): jack-audio-connection-kit-devel pipewire-jack-audio-connection-kit-devel, have choice for nodejs-devel needed by nodejs-packaging: nodejs-devel nodejs16-devel
I tried it like this:
# help decide for dependency
BuildRequires: pipewire-jack-audio-connection-kit-devel
BuildRequires: nodejs16-devel
But that seems to create some conflict with npm16. Maybe we need the "newer" version of nodejs-devel. We could try BuildRequires: nodejs-devel >=17 or something like that for fedora.
@dheidler Odd version numbers of nodejs like 17 are development versions. Even numbers are maintained LTS versions. Most projects use LTS versions and not development versions and if you build them like signal-desktop with nodejs16 it wont work if electron is built with nodejs17!
nodejs-election should be built with nodejs16 on all distributions!
I'm using nodejs16 on all opensuse distros.
I was unable to get resolved build dependencies for fedora otherwise.
Feel free to send a SR to change it on fedora - I myself am happy if it builds at all for fedora as I don't consider it as very important.
I think the system node copy is only used for running the typescript compiler, electron ships its own fork of node (and libuv) inside.
I even tried to unbundle libuv (it is backward compatible; Arch uses system libuv even in ancient node versions) but it did not work — Electron has its own patches not matching any upstream libuv version.
I'm doing a major review of our spec for electron 19 merge, does anyone know why we block building on 32bit platforms? Especially since armv7 is explicitely supported by upstream.
I don't really care about other arches, but right now even arm64 fails to link, which would be a regression. So i'm trying to unbundle some libs (abseil, spirv) to reduce binary size.
Hi, just a user of the repo here on Fedora 37. The package seems to have been rebuilt 6 or 7 times in the past week or so, with no apparent change to the source RPM other than the release number. What's prompted this and what changed?
Bruno Pitrus (dziobian)
committed
(revision 163)
Comments 25
@ithod not sure how to resolve the fedora deps. My latest change didn't really help: https://build.opensuse.org/package/rdiff/devel:languages:nodejs/nodejs-electron?linkrev=base&rev=5
This comment has been deleted
Hm - adding the Prefer: to the spec doesn't seem to have an effect.
This comment has been deleted
I would rather not touch anything outside of this package that could affect other packages in this project. But as I was able to fix something similar for 15.3 using BuildRequires in the spec file, this should be possible for fedora as well.
I tried it like this:
But that seems to create some conflict with npm16. Maybe we need the "newer" version of nodejs-devel. We could try
BuildRequires: nodejs-devel >=17or something like that for fedora.This comment has been deleted
Because we do not have any debug symbols at all.
This comment has been deleted
@dheidler Odd version numbers of nodejs like 17 are development versions. Even numbers are maintained LTS versions. Most projects use LTS versions and not development versions and if you build them like signal-desktop with nodejs16 it wont work if electron is built with nodejs17!
nodejs-election should be built with nodejs16 on all distributions!
I'm using nodejs16 on all opensuse distros. I was unable to get resolved build dependencies for fedora otherwise. Feel free to send a SR to change it on fedora - I myself am happy if it builds at all for fedora as I don't consider it as very important.
Take a look at the tumbleweed build log, it picks nodejs17!
Let's see if my latest change fixes that
I think the system node copy is only used for running the typescript compiler, electron ships its own fork of node (and libuv) inside.
I even tried to unbundle libuv (it is backward compatible; Arch uses system libuv even in ancient node versions) but it did not work — Electron has its own patches not matching any upstream libuv version.
Please branch memory-constraints and build it for Fedora 36 in devel:languages:nodejs
I'm doing a major review of our spec for electron 19 merge, does anyone know why we block building on 32bit platforms? Especially since armv7 is explicitely supported by upstream.
This comment has been deleted
Yes - I think build failed on armv7h and i586 and I'm not sure how to fix that, so it was disabled to save ressources.
I managed to fix all assembling errors, but unfortunately on i586 neither BFD nor GoLD can handle “Google Ultron powered by Download More RAM”.
You could have some entry here: https://build.opensuse.org/package/view_file/devel:languages:nodejs/nodejs-electron/_constraints?expand=1
But I guess you can just have 4GB of RAM in total on i586.
I don't really care about other arches, but right now even arm64 fails to link, which would be a regression. So i'm trying to unbundle some libs (abseil, spirv) to reduce binary size.
Hi, just a user of the repo here on Fedora 37. The package seems to have been rebuilt 6 or 7 times in the past week or so, with no apparent change to the source RPM other than the release number. What's prompted this and what changed?
that usually means that a dependency got rebuilt.
Unfortunately fedora does not have build-compare which would eliminate spurious rebuilds: boo#1206734
Is this a problem specifically for Fedora 36 and later, or has it been for all Fedora versions?
all fedora, it never had reproducible builds on OBS