This request is superseded by
request 1102041
(Show diff)
Overview
Request 1101894 superseded
- update to 1.2.0:
* Added PDF text selection tools
* Added Setsquare Tool and Compass Tool
* Many more changes; for the full list, see
https://github.com/xournalpp/xournalpp/blob/release-1.2/CHANGELOG.md
- remove xournalpp-include.patch, fixed upstream
- Created by ithod
- In state superseded
- Package maintainer: badshah400
- Superseded by 1102041
Loading...
Request History
ithod created request
- update to 1.2.0:
* Added PDF text selection tools
* Added Setsquare Tool and Compass Tool
* Many more changes; for the full list, see
https://github.com/xournalpp/xournalpp/blob/release-1.2/CHANGELOG.md
- remove xournalpp-include.patch, fixed upstream
Looks good, many thanks, except I would prefer if this "error: control reaches end of non-void function" were fixed with a patch and sent upstream instead of being ignored using cflags.
In
src/core/pdf/popplerapi/PopplerGlibPage.cpp:113
it is just ag_assert
which exits the code anyway - I felt a patch is not really required here...Agree, but in case there is a more serious error somewhere else whereby the code reaches an end of non-void function without returning, your cflag will end up hiding it still. Much better to patch this rather in my opinion.