Overview

Request 126491 superseded

- Update to 3.6.6.
+ Fix possible memory leaks in the Samba master process; (bso#8970).
+ Fix uninitialized memory read in talloc_free(); (bnc#764577).
+ Fix joining of XP Pro workstations to 3.6 DCs; (bso#8373).
- resolve_ads() code can return zero addresses and miss valid DC IP addresses;
(bso#8910).
- Can't join XP Pro workstations to 3.6.1 DC; (bso#8373).
- winbind can hang as nbt_getdc() has no timeout; (bso#8953).
- Fix crash bug in dns_create_probe when dns_create_update fails; (bso#8627)
- s3-pid: Catch with pid filename's change when config file is not smb.conf;
(bso#8714).
- Possible memory leaks in the main Samba process; (bso#8970).
- s3: Fix uninitialized memory read in talloc_free(); (bnc#764577).
- Treat exit_server_cleanly() as a "clean" shutdown; (bso#8971).
- Avoid crash with MIT krb5 1.10.0 in gss_get_name_attribute(); (bso#8988).
- Winzip occasionally can not read files out of an open winzip dialog;
(bso#8311).
- s3-winbindd: call dump_core_setup after command line option has been parsed;
(bso#8975).
- Directory group write permission bit is set if unix extensions are enabled;
(bso#8972).
- s3: remove dependency on automake for "make everything"; (bso#8978).
- sd_has_inheritable_components segfaults on an SD that se_access_check
accepts; (bso#8811).
- smbclient's tarmode insists on listing excluded directories; (bso#8922).
- Notify code can miss a ChDir; (bso#8998).
- s3:smbd: add a fsp_persistent_id() function; (bso#8995).

Loading...
Request History
Lars Müller's avatar

lmuelle created request

- Update to 3.6.6.
+ Fix possible memory leaks in the Samba master process; (bso#8970).
+ Fix uninitialized memory read in talloc_free(); (bnc#764577).
+ Fix joining of XP Pro workstations to 3.6 DCs; (bso#8373).
- resolve_ads() code can return zero addresses and miss valid DC IP addresses;
(bso#8910).
- Can't join XP Pro workstations to 3.6.1 DC; (bso#8373).
- winbind can hang as nbt_getdc() has no timeout; (bso#8953).
- Fix crash bug in dns_create_probe when dns_create_update fails; (bso#8627)
- s3-pid: Catch with pid filename's change when config file is not smb.conf;
(bso#8714).
- Possible memory leaks in the main Samba process; (bso#8970).
- s3: Fix uninitialized memory read in talloc_free(); (bnc#764577).
- Treat exit_server_cleanly() as a "clean" shutdown; (bso#8971).
- Avoid crash with MIT krb5 1.10.0 in gss_get_name_attribute(); (bso#8988).
- Winzip occasionally can not read files out of an open winzip dialog;
(bso#8311).
- s3-winbindd: call dump_core_setup after command line option has been parsed;
(bso#8975).
- Directory group write permission bit is set if unix extensions are enabled;
(bso#8972).
- s3: remove dependency on automake for "make everything"; (bso#8978).
- sd_has_inheritable_components segfaults on an SD that se_access_check
accepts; (bso#8811).
- smbclient's tarmode insists on listing excluded directories; (bso#8922).
- Notify code can miss a ChDir; (bso#8998).
- s3:smbd: add a fsp_persistent_id() function; (bso#8995).


Factory Auto's avatar

factory-auto added a reviewer

Please review sources


Andreas Jaeger's avatar

a_jaeger declined request

You remove this line from changes:
-- Don't call autogen.sh on post-12.1 SUSE and post-14 Fedora systems.

And also do the following in the spec file:
-%if 0%{?centos_version} > 599 || 0%{?fedora_version} > 11 && 0%{?fedora_version} < 15 || 0%{?mandriva_version} > 2009 || 0%{?rhel_version} > 599 || 0%{?suse_version} > 0 && 0%{?suse_version} < 1211
+%if 0%{?centos_version} > 599 || 0%{?fedora_version} > 11 && 0%{?fedora_version} < 15 || 0%{?mandriva_version} > 2009 || 0%{?rhel_version} > 599 || 0%{?suse_version} > 0

If the spec file change is intentional, please add a new changes entry saying so, instead of
removing the line from samba.changes

The rest looks fine. Please correct the above and resubmit.


Lars Müller's avatar

lmuelle superseded request

- ndr: fix push/pull DATA_BLOB with NDR_NOALIGN; (bso#9026); (bnc#770262).
- Fix shell syntax in dhcpcd hook script; (bnc#769957).
- Update to 3.6.6.
+ Fix possible memory leaks in the Samba master process; (bso#8970).
+ Fix uninitialized memory read in talloc_free(); (bnc#764577).
+ Fix joining of XP Pro workstations to 3.6 DCs; (bso#8373).
- resolve_ads() code can return zero addresses and miss valid DC IP addresses;
(bso#8910).
- Can't join XP Pro workstations to 3.6.1 DC; (bso#8373).
- winbind can hang as nbt_getdc() has no timeout; (bso#8953).
- Fix crash bug in dns_create_probe when dns_create_update fails; (bso#8627)
- s3-pid: Catch with pid filename's change when config file is not smb.conf;
(bso#8714).
- Possible memory leaks in the main Samba process; (bso#8970).
- s3: Fix uninitialized memory read in talloc_free(); (bnc#764577).
- Treat exit_server_cleanly() as a "clean" shutdown; (bso#8971).
- Avoid crash with MIT krb5 1.10.0 in gss_get_name_attribute(); (bso#8988).
- Winzip occasionally can not read files out of an open winzip dialog;
(bso#8311).
- s3-winbindd: call dump_core_setup after command line option has been parsed;
(bso#8975).
- Directory group write permission bit is set if unix extensions are enabled;
(bso#8972).
- s3: remove dependency on automake for "make everything"; (bso#8978).
- sd_has_inheritable_components segfaults on an SD that se_access_check
accepts; (bso#8811).
- smbclient's tarmode insists on listing excluded directories; (bso#8922).
- Notify code can miss a ChDir; (bso#8998).
- s3:smbd: add a fsp_persistent_id() function; (bso#8995).
- Call autogen.sh even on post-12.1 SUSE systems.
- Include the reviewed french translation for pam_winbind; (bnc#499233).


Saul Goodman's avatar

licensedigger accepted review

{"approve": "preliminary, version number changed"}


Factory Auto's avatar

factory-auto accepted review

Builds for repo openSUSE_Factory


Andreas Jaeger's avatar

a_jaeger declined review

You remove this line from changes:
-- Don't call autogen.sh on post-12.1 SUSE and post-14 Fedora systems.

And also do the following in the spec file:
-%if 0%{?centos_version} > 599 || 0%{?fedora_version} > 11 && 0%{?fedora_version} < 15 || 0%{?mandriva_version} > 2009 || 0%{?rhel_version} > 599 || 0%{?suse_version} > 0 && 0%{?suse_version} < 1211
+%if 0%{?centos_version} > 599 || 0%{?fedora_version} > 11 && 0%{?fedora_version} < 15 || 0%{?mandriva_version} > 2009 || 0%{?rhel_version} > 599 || 0%{?suse_version} > 0

If the spec file change is intentional, please add a new changes entry saying so, instead of
removing the line from samba.changes

The rest looks fine. Please correct the above and resubmit.

openSUSE Build Service is sponsored by