Overview

Request 151476 superseded

New package for Factory; see http://lists.opensuse.org/opensuse-factory/2013-01/msg00433.html

Loading...
Request History
Archie Cobbs's avatar

archie172 created request

New package for Factory; see http://lists.opensuse.org/opensuse-factory/2013-01/msg00433.html


Saul Goodman's avatar

licensedigger added a reviewer

{"delegate": "new package r>3"}


Saul Goodman's avatar

licensedigger accepted review

{"delegate": "new package r>3"}


Factory Auto's avatar

factory-auto accepted review

Builds for repo openSUSE_Factory_PowerPC


Factory Auto's avatar

factory-auto added a reviewer

Please review sources


Ciaran Farrell's avatar

babelworx accepted review


Andreas Jaeger's avatar

a_jaeger declined review

Hi,

I have some more requests:

Adding a user home directory under /usr/share is not a good idea, especially since /usr
should be able to be mounted read-only. If needed, create it under /var. Please ask
on opensuse-packaging on how to do this best.

The rewriting of the ssh configuration that your package is doing is nothing that should
be done at install time. I suggest to add a README file that explains what needs to be
done. You can also add a simple script that does this and reference it from the README - but
let the admin execute the commands when wanted and not do this automatically.
Feel free to discuss this as well on opensuse-packing mailing list.

Btw. I've asked the security team for an audit of the package, this audit will not block
the review.

Thanks,
Andreas


Andreas Jaeger's avatar

a_jaeger declined request

Hi,

I have some more requests:

Adding a user home directory under /usr/share is not a good idea, especially since /usr
should be able to be mounted read-only. If needed, create it under /var. Please ask
on opensuse-packaging on how to do this best.

The rewriting of the ssh configuration that your package is doing is nothing that should
be done at install time. I suggest to add a README file that explains what needs to be
done. You can also add a simple script that does this and reference it from the README - but
let the admin execute the commands when wanted and not do this automatically.
Feel free to discuss this as well on opensuse-packing mailing list.

Btw. I've asked the security team for an audit of the package, this audit will not block
the review.

Thanks,
Andreas


Archie Cobbs's avatar

archie172 superseded request

New package for Factory; see http://lists.opensuse.org/opensuse-factory/2013-01/msg00433.html

openSUSE Build Service is sponsored by