Overview
Request 239720 superseded
- Created by msmeissn
- In state superseded
- Supersedes 239716
- Superseded by 241107
Request History
msmeissn created request
factory-auto accepted review
Check script succeeded
factory-auto added a reviewer
Please review sources
factory-auto added a reviewer
Please review build success
factory-auto added a reviewer
Pick Staging Project
licensedigger accepted review
{"delegate": "new package ldb.risk is None"}
licensedigger added a reviewer
{"delegate": "new package ldb.risk is None"}
factory-repo-checker accepted review
Builds for repo graphics/openSUSE_Factory
coolo accepted review
No need for staging, not in tested ring projects.
babelworx accepted review
dimstar declined review
+%package -n %{_libname}
+License: GPL-3.0+ and LGPL-3.0+
+Summary: Computational Geometry Algorithms Library
+Group: Productivity/Graphics/CAD
=> Libraries are per definition to be put in the RPM Group System/Libraries
+%fdupes doc_html at the beginning of %install looks 'strange' (not wrong, but strange). And in plus, it does not have the effect that was expected, as can be seen in the log:
cgal-doc.noarch: E: files-duplicated-waste (Badness: 100) 2655090
The %exluce statement must only be use to remove a file from a glob when the same file appears in a different package, so:
+%exclude %{_bindir}/cgal_make_macosx_app
is not valid in this case (as cgal_make_macosx_app is not packagaed anywhere else. In this case, it's correct to rm the file during install
(exclude can have very funny side effects in case of 'real' binaries; this one is likely only a script)
dimstar declined request
+%package -n %{_libname}
+License: GPL-3.0+ and LGPL-3.0+
+Summary: Computational Geometry Algorithms Library
+Group: Productivity/Graphics/CAD
=> Libraries are per definition to be put in the RPM Group System/Libraries
+%fdupes doc_html at the beginning of %install looks 'strange' (not wrong, but strange). And in plus, it does not have the effect that was expected, as can be seen in the log:
cgal-doc.noarch: E: files-duplicated-waste (Badness: 100) 2655090
The %exluce statement must only be use to remove a file from a glob when the same file appears in a different package, so:
+%exclude %{_bindir}/cgal_make_macosx_app
is not valid in this case (as cgal_make_macosx_app is not packagaed anywhere else. In this case, it's correct to rm the file during install
(exclude can have very funny side effects in case of 'real' binaries; this one is likely only a script)
superseded by 241107
