Overview

Request 447602 accepted

No description set

Adam Majer's avatar

Can you simplify the requirements?

+%if 0%{?suse_version} < 1315 || 0%{?suse_version} > 1316 +BuildRequires: nodejs-packaging +BuildRequires: npm4 +BuildRequires: nodejs4-devel +%endif +%if 0%{?suse_version} == 1316 +BuildRequires: nodejs-devel +%endif

This should be simplified to just nodejs-packaging. Nodejs-packaging should pull nodejs in. If there are ambiguities, then that can be fixed in project config.

+%if 0%{?suse_version} >= 1315 || 0%{?suse_version} <= 1316 +%define nodejs_sitelib /usr/lib/node_modules +%endif

This condition is kind of useless - it always matches. Drop the %if completely.


Marguerite Su's avatar

and ios/android really needed for openSUSE? I even see *.php...

Request History
Hillwood Yang's avatar

hillwood created request


Adam Majer's avatar

adamm accepted request

You could use build conditions instead of define, so `bcond_with android` and then %if %{with android} ... etc.. but accepted as is. Also, build-requires should only depend on nodejs-devel and npm, and project config should resolve the rest. For next version. ;) Thanks.

openSUSE Build Service is sponsored by