Overview

Request 507763 superseded

- Add ncurses patch 20170701 (bsc#1046853, bsc#1046858)
+ modify update_getenv() in db_iterator.c to ensure that environment
variables which are not initially set will be checked later if an
application happens to set them (patch by Guillaume Maudoux).
+ remove initialization-check for calling napms() in the term-driver
configuration; none is needed.
+ add help-screen to test/test_getstr.c and test/test_get_wstr.c
+ improve compatibility between different configurations of new_prescr,
fixing a case with threaded code and term-driver where c++/demo did
not work (cf: 20160213).
+ the fixes for Redhat #1464685 obscured a problem subsequently
reported in Redhat #1464687; the given test-case was no longer
reproducible. Testing without the fixes for the earlier reports
showed a problem with buffer overflow in dump_entry.c, which is
addressed by reducing the use of a fixed-size buffer.
+ add/improve checks in tic's parser to address invalid input
(Redhat #1464684, #1464685, #1464686, #1464691).
+ alloc_entry.c, add a check for a null-pointer.
+ parse_entry.c, add several checks for valid pointers as well as
one check to ensure that a single character on a line is not
treated as the 2-character termcap short-name.
+ fix a memory leak in delscreen() (report by Bai Junq).
+ improve tracemunch, showing thread identifiers as names.
+ fix a use-after-free in NCursesMenu::~NCursesMenu()
+ further amend incorrect calls for memory-leaks from 20170617 changes
(report by Allen Hewes).

- Add ncurses patch 20170624
+ modify c++/etip.h.in to accommodate deprecation of throw() and
throws() in c++17 (prompted by patch by Romain Geissler).

Max Lin's avatar
Max Lin (mlin7442) -

breaks libyui-ncurses

[   50s] In file included from /home/abuild/rpmbuild/BUILD/libyui-ncurses-2.48.2/src/ncursesw.h:30:0,
[   50s]                  from /home/abuild/rpmbuild/BUILD/libyui-ncurses-2.48.2/src/ncursesp.h:30,
[   50s]                  from /home/abuild/rpmbuild/BUILD/libyui-ncurses-2.48.2/src/ncursesp.cc:60:
[   50s] /usr/include/ncursesw/etip.h: In function 'void THROW(const NCursesException*)':
[   50s] /usr/include/ncursesw/etip.h:352:9: error: '::endwin' has not been declared
[   50s]        ::endwin();
[   50s]          ^~~~~~
[   50s] /usr/include/ncursesw/etip.h:352:9: note: suggested alternative: 'stdin'
[   50s]        ::endwin();
[   50s]          ^~~~~~
[   50s]          stdin
[   50s] [ 23%] Building CXX object src/CMakeFiles/yui-ncurses.dir/NCstyle.cc.o
[   51s] [ 25%] Building CXX object src/CMakeFiles/yui-ncurses.dir/NCStyleDef.cc.o
[   51s] make[2]: *** [src/CMakeFiles/yui-ncurses.dir/build.make:351: src/CMakeFiles/yui-ncurses.dir/ncursesp.cc.o] Error 1
[   51s] make[2]: *** Waiting for unfinished jobs....
[   51s] In file included from /home/abuild/rpmbuild/BUILD/libyui-ncurses-2.48.2/src/ncursesw.h:30:0,
[   51s]                  from /home/abuild/rpmbuild/BUILD/libyui-ncurses-2.48.2/src/ncursesw.cc:57:
[   51s] /usr/include/ncursesw/etip.h: In function 'void THROW(const NCursesException*)':
[   51s] /usr/include/ncursesw/etip.h:352:9: error: '::endwin' has not been declared
[   51s]        ::endwin();
[   51s]          ^~~~~~
[   51s] /usr/include/ncursesw/etip.h:352:9: note: suggested alternative: 'stdin'
[   51s]        ::endwin();
[   51s]          ^~~~~~
[   51s]          stdin
[   51s] make[2]: *** [src/CMakeFiles/yui-ncurses.dir/build.make:327: src/CMakeFiles/yui-ncurses.dir/ncursesw.cc.o] Error 1
[   55s] make[1]: *** [CMakeFiles/Makefile2:150: src/CMakeFiles/yui-ncurses.dir/all] Error 2

I filed bug report https://bugzilla.suse.com/show_bug.cgi?id=1047867

Request History
Dr. Werner Fink's avatar

WernerFink created request

- Add ncurses patch 20170701 (bsc#1046853, bsc#1046858)
+ modify update_getenv() in db_iterator.c to ensure that environment
variables which are not initially set will be checked later if an
application happens to set them (patch by Guillaume Maudoux).
+ remove initialization-check for calling napms() in the term-driver
configuration; none is needed.
+ add help-screen to test/test_getstr.c and test/test_get_wstr.c
+ improve compatibility between different configurations of new_prescr,
fixing a case with threaded code and term-driver where c++/demo did
not work (cf: 20160213).
+ the fixes for Redhat #1464685 obscured a problem subsequently
reported in Redhat #1464687; the given test-case was no longer
reproducible. Testing without the fixes for the earlier reports
showed a problem with buffer overflow in dump_entry.c, which is
addressed by reducing the use of a fixed-size buffer.
+ add/improve checks in tic's parser to address invalid input
(Redhat #1464684, #1464685, #1464686, #1464691).
+ alloc_entry.c, add a check for a null-pointer.
+ parse_entry.c, add several checks for valid pointers as well as
one check to ensure that a single character on a line is not
treated as the 2-character termcap short-name.
+ fix a memory leak in delscreen() (report by Bai Junq).
+ improve tracemunch, showing thread identifiers as names.
+ fix a use-after-free in NCursesMenu::~NCursesMenu()
+ further amend incorrect calls for memory-leaks from 20170617 changes
(report by Allen Hewes).

- Add ncurses patch 20170624
+ modify c++/etip.h.in to accommodate deprecation of throw() and
throws() in c++17 (prompted by patch by Romain Geissler).

Factory Auto's avatar

factory-auto added opensuse-review-team as a reviewer

Please review sources

Factory Auto's avatar

factory-auto added factory-repo-checker as a reviewer

Please review build success

Factory Auto's avatar

factory-auto accepted review

Check script succeeded

Saul Goodman's avatar

licensedigger accepted review

ok

Dominique Leuenberger's avatar

dimstar_suse set openSUSE:Factory:Staging:C as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:C"

Dominique Leuenberger's avatar

dimstar_suse accepted review

Picked openSUSE:Factory:Staging:C

Factory Repo Checker's avatar

factory-repo-checker accepted review

Builds for repo openSUSE:Factory:Staging:C/standard

Yuchen Lin's avatar

maxlin_factory accepted review

Removing from openSUSE:Factory:Staging:C, re-evaluation needed

Yuchen Lin's avatar

maxlin_factory added factory-staging as a reviewer

Requesting new staging review

mrdocs's avatar

mrdocs accepted review

ok

Yuchen Lin's avatar

maxlin_factory set openSUSE:Factory:Staging:A as a staging project

Being evaluated by staging project "openSUSE:Factory:Staging:A"

Yuchen Lin's avatar

maxlin_factory accepted review

Picked openSUSE:Factory:Staging:A

Dr. Werner Fink's avatar

WernerFink superseded request

superseded by 509084

openSUSE Build Service is sponsored by
Places