Overview
Request 515328 superseded
- go-race: add compiler-rt TSAN binary, necessary for the race detector builds
to work. This requires building compiler-rt from source (becuase upstream Go
stores precompiled binaries in the tree, and we cannot use them). In
addition, a %check was added purely to ensure that we don't install the wrong
version of compiler-rt. boo#1052528
- go-rpmlintrc: add some entries to address the .syso additions.
- Created by cyphar
- In state superseded
- Superseded by 517313
- Open review for thipp
Request History
cyphar created request
- go-race: add compiler-rt TSAN binary, necessary for the race detector builds
to work. This requires building compiler-rt from source (becuase upstream Go
stores precompiled binaries in the tree, and we cannot use them). In
addition, a %check was added purely to ensure that we don't install the wrong
version of compiler-rt. boo#1052528
- go-rpmlintrc: add some entries to address the .syso additions.
cyphar added thipp as a reviewer
superseded by 517313
great catch with the binaries that we shipped, we shipped them even for windows and other non-linux distros, which is really useless
also creating a separate package makes sense to me
lgtm
@MargueriteSu: review reminder
Also @thipp.
Shouldn't there be an
ifarch %{tsan_arch}
block around line 83 and 126?It's not necessary because the source is provided in both cases, regardless of arch. But maybe we should just %ifarch it out. My concern is that the %setup flags might break, but I can give it a shot.