Overview
Request 590434 superseded
c-toxcore - Tox protocol implementation library
- Created by sleep_walker
- In state superseded
- Superseded by 592844
- Open review for openSUSE:Factory:Staging:adi:9
Request History
sleep_walker created request
c-toxcore - Tox protocol implementation library
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
staging-bot added openSUSE:Factory:Staging:adi:9 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:9"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:9
repo-checker accepted review
cycle and install check passed
licensedigger accepted review
ok
dimstar declined review
Declining - please see the comments posted on https://build.opensuse.org/request/show/590434
dimstar declined request
Declining - please see the comments posted on https://build.opensuse.org/request/show/590434
sleep_walker superseded request
superseded by 592844
ad user/group rpmlint rant - I prepared request 590417
and it was accepted so it will be OK eventually
There are a couple things to address:
BuildRequires: check
: you already buildrequire check-devel, that seems redundantBuildRequires: cmake
: the build system seems to use automake (which you also buildrequire)BuildRequires: systemd
: please use pkgconfig(systemd), so that OBS can optimize the build chainsBuildRequires: systemd-sysvinit
somewhat makes very little sense in the buildroot. If the build system checks for anything from that package, the buildsystem ought to be fixed