Overview
Request 592844 accepted
c-toxcore - Tox protocol implementation library
I followed dimstar's feedback and addressed all the problems he
mentioned (thanks for thourough review!)
- Created by sleep_walker
- In state accepted
- Supersedes 590434
ad user/group rpmlint rant - I prepared request 590417
and it was accepted so it will be OK eventually
There are a couple things to address:
- Do not package static libs, or if you have to, package them in a -devel-static package (so it can be easily tracked what really buildrequires it)
- %post -p /sbin/ldconfig unneeded, as there are no files in the main package
- Just curious:
BuildRequires: check: you already buildrequire check-devel, that seems redundant -
BuildRequires: cmake: the build system seems to use automake (which you also buildrequire) -
BuildRequires: systemd: please use pkgconfig(systemd), so that OBS can optimize the build chains -
BuildRequires: systemd-sysvinitsomewhat makes very little sense in the buildroot. If the build system checks for anything from that package, the buildsystem ought to be fixed
Request History
sleep_walker created request
c-toxcore - Tox protocol implementation library
I followed dimstar's feedback and addressed all the problems he
mentioned (thanks for thourough review!)
licensedigger accepted review
ok
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
dimstar accepted review
staging-bot added openSUSE:Factory:Staging:adi:9 as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:adi:9"
staging-bot accepted review
Picked openSUSE:Factory:Staging:adi:9
repo-checker accepted review
cycle and install check passed
staging-bot accepted review
ready to accept
staging-bot approved review
ready to accept
dimstar_suse accepted request
Accept to openSUSE:Factory
