Overview
Request 649571 superseded
- update to current 0.27-RC2 git state to fix SONAME
change issues
- drop exiv2-0.27-rc2-branch.patch: built git tarball instead.
- update to 0.27-RC1:
* Security Fixes.
* New build and test infrastructure.
* Many bug fixes.
* Support for MinGW/msys2.
* Buildserver rewritten.
* Support for Adobe XMPsdk
- drop exiv2-update-to-0.26-branch.patch, parallel-build-dep.patch: obsolete
- add exiv2-0.27-rc2-branch.patch: add fixes staged for RC2
- Created by dirkmueller
- In state superseded
- Supersedes 649525
- Superseded by 653678
- Open review for repo-checker
- Open review for openSUSE:Factory:Staging:J
A backwards jump of the SO version? Something looks wrong (if only at the upstream level)!
They fixed it already in commit 8b877d6ed6db006d32104389dca0900feec54bf7 (a little ahead of RC1).
I'd say we should not move forward without commit 8b877d6e to get the right sonum in place (and sad to see another upstream that bases their sover on the product version, instead of the API/ABI in use)
abidiff libexiv2.so.26 libexiv2.so.0
Function symbols changes summary: 2022 Removed, 40 Added function symbols not referenced by debug info Variable symbols changes summary: 806 Removed, 0 Added variable symbols not referenced by debug info
Their ABI did change, that's for sure, so a bump (to 27) is justified. I'll pretend they just snuck a leading "0." into their version, but are otherwise using semver (https://semver.org/ ), so that, in fact, "0.27" is actually product version major 27.0 not product version 0.27, but who's counting.
If you follow semver specification closely then you see that projects which have a "0" major version are not yet following the rules by semver, e.g. anything can change any time. :-)
Request History
dirkmueller created request
- update to current 0.27-RC2 git state to fix SONAME
change issues
- drop exiv2-0.27-rc2-branch.patch: built git tarball instead.
- update to 0.27-RC1:
* Security Fixes.
* New build and test infrastructure.
* Many bug fixes.
* Support for MinGW/msys2.
* Buildserver rewritten.
* Support for Adobe XMPsdk
- drop exiv2-update-to-0.26-branch.patch, parallel-build-dep.patch: obsolete
- add exiv2-0.27-rc2-branch.patch: add fixes staged for RC2
factory-auto added opensuse-review-team as a reviewer
Please review sources
factory-auto added repo-checker as a reviewer
Please review build success
factory-auto accepted review
Check script succeeded
alarrosa accepted review
ok
staging-bot added openSUSE:Factory:Staging:D as a reviewer
Being evaluated by staging project "openSUSE:Factory:Staging:D"
staging-bot accepted review
Picked openSUSE:Factory:Staging:D
dimstar_suse set openSUSE:Factory:Staging:J as a staging project
Being evaluated by staging project "openSUSE:Factory:Staging:J"
dimstar_suse accepted review
Moved to openSUSE:Factory:Staging:J
licensedigger accepted review
ok
dimstar_suse superseded request
superseded by 653678
neither libgexiv nor libkexiv seem yet ready for this update
CCing respective maintainers:
libkevix2: @tittiatcoke @luca_b @wolfi323 @cgiboudeaux @Vogtinator @alarrosa
libgexiv2: @luc14n0
status update: - Fixes were pushed for krename, gwenview and I'll look at the others later - Due to some API becoming private in exiv 0.27 (https://github.com/Exiv2/exiv2/commit/4574a659), even with a CMake fix, krita fails to build.
There's an issue with the libexiv2-devel-0.27~RC2-98.1.x86_64.rpm package, the pkgconfig file contains "libdir=${prefix}/lib"
Fixes were pushed upstream
How is
libdir=${prefix}/lib
wrong? Many .pc files have a dollar there. (yeah it should belib64
...)you already have the answer :) lib vs. lib64
Also: https://github.com/Exiv2/exiv2/issues/555. The fix is needed for both libgexiv2 and kphotoalbum
Additional failures related to this SR:
CC @tittiatcoke @luca_b @wolfi323 @cgiboudeaux @Vogtinator @alarrosa (gewnview5) CC @dimstar and @sreeves1 (g-c-m)
For gwenview:
Looks like the cmake module can't find the right version, or there's something messing up version detection. @krop?
Sounds like it could be a regex like
^(\d+)\.(\d+)$
with an extraneous $ that does not cope with a-rc2
suffix.for the KDE apps, it's because the version #define were moved from version.hpp to exv_conf.h.
yeah, why would anybody expect VERSION defines in a file called version.hpp :P
For the GNOME apps: exiv2/xmp.hpp was renamed exiv2/xmp_exiv2.hpp (upstream didn't hear about source compatibility it seems)
Thanks for the pointer