Deal with bug in SUSE's cmake macro that was fixed in Fedora long ago..

rpm --eval %cmake here shows "-DCMAKE_INSTALL_LIBDIR:PATH=/usr/lib64" so this isn't true?

Javier Llorente (javierllorente) - over 5 years ago

author target maintainer

You're right. No need to add that.

What's this supposed to do?

Requires: %{libname}%{?_isa} = %{version}-%{release}

Javier Llorente (javierllorente) - over 5 years ago

author target maintainer

It expands to libqobs1(x86_64) = 1.0.1-1 http://rpm.org/user_doc/arch_dependencies.html

---

Javier Llorente (javierllorente) - over 5 years ago

author target maintainer

Oops, I mean 1.0.1-0 (Release is 0)

For SUSE Linux < 15

%{!?make_build: %global make_build %{__make} %{?_smp_mflags}}

Then it's missing %if %endif and the comment should be fixed. Is it for SLES or openSUSE?

Group: Utility/Development/Other

This group doesn't exist. https://en.opensuse.org/openSUSE:Package_group_guidelines

Deal with bug in SUSE's cmake macro that was fixed in Fedora long ago...

The comment is incorrect, it should be: "Deal with a bug in qactus' build system which is unable to treat absolute paths correctly"

Then it's missing %if %endif and the comment should be fixed. Is it for SLES or openSUSE? I don't know. I didn't write it myself. Since it compiles fine for openSUSE Tumbleweed, I have removed it.

Group: Utility/Development/Other Fixed

The comment is incorrect, it should be: "Deal with a bug in qactus' build system which is unable to treat absolute paths correctly" It deals fine with paths. Anyways, I have removed it, since it's not needed

Thanks for your feedback. I'll submit a fixed spec.